[PR #537] [MERGED] fix redis sentinel url parse #2791

New issue

Closed

opened 2026-03-15 21:03:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 21:03:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/537
Author: @sillydong
Created: 9/9/2022
Status: ✅ Merged
Merged: 9/25/2022
Merged by: @hibiken

Base: master ← Head: fix-redis-sentinel-parse-url

📝 Commits (1)

ffbb8f1 fix redis sentinel url parse

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 asynq.go (+1 -1)
📝 asynq_test.go (+3 -3)

📄 Description

It is actually using SentinelPassword to do sentinel authentication, see from the code

If we set Password from url instead of setting SentinelPassword, we will meet such error

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/537 **Author:** [@sillydong](https://github.com/sillydong) **Created:** 9/9/2022 **Status:** ✅ Merged **Merged:** 9/25/2022 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `fix-redis-sentinel-parse-url` --- ### 📝 Commits (1) - [`ffbb8f1`](https://github.com/hibiken/asynq/commit/ffbb8f106b14c0773f0dc5844081d720377f9f97) fix redis sentinel url parse ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `asynq.go` (+1 -1) 📝 `asynq_test.go` (+3 -3) </details> ### 📄 Description It is actually using SentinelPassword to do sentinel authentication, see from the code ![image](https://user-images.githubusercontent.com/1894696/189259785-d0822d45-ffb2-4136-9d2c-9a1852f915c9.png) If we set Password from url instead of setting SentinelPassword, we will meet such error <img width="1003" alt="image" src="https://user-images.githubusercontent.com/1894696/189259700-38148d9d-3208-42e0-920c-236f6664cc92.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 21:03:40 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#2791

No description provided.

Rows
Columns