[PR #252] [MERGED] Refactor redis key and store messages in protobuf #2709

New issue

Closed

opened 2026-03-15 20:59:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 20:59:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/252
Author: @hibiken
Created: 3/12/2021
Status: ✅ Merged
Merged: 3/13/2021
Merged by: @hibiken

Base: next ← Head: refactor/redis-key

📝 Commits (10+)

fae6c4b Rename pending key
0b04331 Add TaskKey helper
16d8fa4 Update TaskKey helper to task id as string
2bef331 Update RDB.Enqueue
4ba0e46 Update RDB.EnqueueUniqueue
69b7aa2 Update RDB.Schedule
9e7897a Update RDB.ScheduleUnique
b156653 Code formatting
26caccb Update RDB.ForwardIfReady
a745b23 Update RDB.Done

📊 Changes

22 files changed (+2534 additions, -587 deletions)

View changed files

📝 .gitignore (+4 -1)
📝 CHANGELOG.md (+5 -0)
➕ Makefile (+7 -0)
📝 README.md (+1 -1)
📝 client_test.go (+3 -3)
📝 forwarder.go (+1 -1)
📝 forwarder_test.go (+1 -1)
📝 go.mod (+4 -2)
📝 go.sum (+58 -0)
📝 inspeq/inspector.go (+14 -11)
📝 inspeq/inspector_test.go (+6 -7)
📝 internal/asynqtest/asynqtest.go (+74 -56)
📝 internal/base/base.go (+275 -20)
📝 internal/base/base_test.go (+162 -3)
➕ internal/proto/asynq.pb.go (+755 -0)
➕ internal/proto/asynq.proto (+148 -0)
📝 internal/rdb/benchmark_test.go (+2 -2)
📝 internal/rdb/inspect.go (+289 -211)
📝 internal/rdb/inspect_test.go (+413 -78)
📝 internal/rdb/rdb.go (+246 -134)

...and 2 more files

📄 Description

Closes #245

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/252 **Author:** [@hibiken](https://github.com/hibiken) **Created:** 3/12/2021 **Status:** ✅ Merged **Merged:** 3/13/2021 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `next` ← **Head:** `refactor/redis-key` --- ### 📝 Commits (10+) - [`fae6c4b`](https://github.com/hibiken/asynq/commit/fae6c4bdc8c96a735d249064a71a267d1839e80b) Rename pending key - [`0b04331`](https://github.com/hibiken/asynq/commit/0b043318ba6803aaaeceebe98c914af4de6f6ec2) Add TaskKey helper - [`16d8fa4`](https://github.com/hibiken/asynq/commit/16d8fa4b9172f83db6534f712288d538489d011b) Update TaskKey helper to task id as string - [`2bef331`](https://github.com/hibiken/asynq/commit/2bef3319c7f5a6626fd03e1403eab061d74c2088) Update RDB.Enqueue - [`4ba0e46`](https://github.com/hibiken/asynq/commit/4ba0e46f96497f7f7736e0abadab30bfdf184a30) Update RDB.EnqueueUniqueue - [`69b7aa2`](https://github.com/hibiken/asynq/commit/69b7aa22cd92609b9a0af41f49fcf0416cec1608) Update RDB.Schedule - [`9e7897a`](https://github.com/hibiken/asynq/commit/9e7897ae0c7ed958021c2bd385631ded46792762) Update RDB.ScheduleUnique - [`b156653`](https://github.com/hibiken/asynq/commit/b15665324336f870e3ac0667cc477910110d1ad3) Code formatting - [`26caccb`](https://github.com/hibiken/asynq/commit/26caccbefd5be86c581076b25a09e04c5ed012c6) Update RDB.ForwardIfReady - [`a745b23`](https://github.com/hibiken/asynq/commit/a745b2378a7b08fbc9ce7caf3440e99870e34bef) Update RDB.Done ### 📊 Changes **22 files changed** (+2534 additions, -587 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+4 -1) 📝 `CHANGELOG.md` (+5 -0) ➕ `Makefile` (+7 -0) 📝 `README.md` (+1 -1) 📝 `client_test.go` (+3 -3) 📝 `forwarder.go` (+1 -1) 📝 `forwarder_test.go` (+1 -1) 📝 `go.mod` (+4 -2) 📝 `go.sum` (+58 -0) 📝 `inspeq/inspector.go` (+14 -11) 📝 `inspeq/inspector_test.go` (+6 -7) 📝 `internal/asynqtest/asynqtest.go` (+74 -56) 📝 `internal/base/base.go` (+275 -20) 📝 `internal/base/base_test.go` (+162 -3) ➕ `internal/proto/asynq.pb.go` (+755 -0) ➕ `internal/proto/asynq.proto` (+148 -0) 📝 `internal/rdb/benchmark_test.go` (+2 -2) 📝 `internal/rdb/inspect.go` (+289 -211) 📝 `internal/rdb/inspect_test.go` (+413 -78) 📝 `internal/rdb/rdb.go` (+246 -134) _...and 2 more files_ </details> ### 📄 Description Closes #245 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 20:59:04 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#2709

No description provided.

Rows
Columns