[PR #205] [MERGED] Add tls support to command line tool #2681

New issue

Closed

opened 2026-03-15 20:57:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 20:57:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/205
Author: @strobus
Created: 10/14/2020
Status: ✅ Merged
Merged: 10/14/2020
Merged by: @hibiken

Base: master ← Head: feat/tool-add-tls-support

📝 Commits (1)

5878289 add tls support to command line tool

📊 Changes

2 files changed (+29 additions, -10 deletions)

View changed files

📝 tools/asynq/cmd/root.go (+27 -10)
📝 tools/go.sum (+2 -0)

📄 Description

This PR adds a --tls_server argument to the CLI tool. Provide the name of a server that is included in the redis server or cluster's certificate. Note, the tls.Config struct only allows one server to be added for validation see crypto/tls. A future enhancement could provide additional arguments for specifying client certificates, etc., though such use cases may be infrequent for redis.

Note: this has been tested with cluster mode. Thank you for adding that!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/205 **Author:** [@strobus](https://github.com/strobus) **Created:** 10/14/2020 **Status:** ✅ Merged **Merged:** 10/14/2020 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `feat/tool-add-tls-support` --- ### 📝 Commits (1) - [`5878289`](https://github.com/hibiken/asynq/commit/587828919eced6a6b5389ac5671062a878844caf) add tls support to command line tool ### 📊 Changes **2 files changed** (+29 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `tools/asynq/cmd/root.go` (+27 -10) 📝 `tools/go.sum` (+2 -0) </details> ### 📄 Description This PR adds a `--tls_server` argument to the CLI tool. Provide the name of a server that is included in the redis server or cluster's certificate. Note, the `tls.Config` struct only allows one server to be added for validation see [crypto/tls](https://golang.org/pkg/crypto/tls/#Config). A future enhancement could provide additional arguments for specifying client certificates, etc., though such use cases may be infrequent for redis. Note: this has been tested with cluster mode. Thank you for adding that! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 20:57:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#2681

No description provided.

Rows
Columns