mirror of
https://github.com/hibiken/asynq.git
synced 2026-04-26 07:25:56 +03:00
[GH-ISSUE #618] [BUG] Wiki docs use "SetDefaultOptions" when it's deprecated #2328
Labels
No labels
CLI
bug
designing
documentation
duplicate
enhancement
good first issue
good first issue
help wanted
idea
invalid
investigate
needs-more-info
performance
pr-welcome
pull-request
question
wontfix
work in progress
work in progress
work-around-available
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asynq#2328
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sushi30 on GitHub (Feb 21, 2023).
Original GitHub issue: https://github.com/hibiken/asynq/issues/618
Originally assigned to: @hibiken on GitHub.
Describe the bug
It appears
SetDefaultOptionswas deprecated. It is still referenced in the docs: https://github.com/hibiken/asynq/wiki/Task-Retry#customize-task-max-retryI did not change because I am a new user to the library so I am not sure what is the correct fix for this doc.
@fivezjd commented on GitHub (Mar 10, 2023):
The latest version has three methods to set MaxRetry:
t1 := NewTask("shometype", nil, MaxRetry(10))client.Enqueue(t1, MaxRetry(10))client.EnqueueContext(context.Background(), t1, MaxRetry(10))The latter two methods will override the former one. here
@hibiken commented on GitHub (Apr 7, 2023):
Thanks for reporting this issue. Fixed :)