mirror of
https://github.com/hibiken/asynq.git
synced 2026-04-26 07:25:56 +03:00
[GH-ISSUE #453] Test goleak is outdated VerifyNoLeaks -> VerifyNone #209
Labels
No labels
CLI
bug
designing
documentation
duplicate
enhancement
good first issue
good first issue
help wanted
idea
invalid
investigate
needs-more-info
performance
pr-welcome
pull-request
question
wontfix
work in progress
work in progress
work-around-available
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asynq#209
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anupriya17 on GitHub (May 7, 2022).
Original GitHub issue: https://github.com/hibiken/asynq/issues/453
Originally assigned to: @MohabMohamed on GitHub.
The goleak made changes while ago and it was not updated in asynq test cases
github.com/hibiken/asynq@245d4fe663/server_test.go (L23)Please check the readme
VerifyNone
@hibiken commented on GitHub (May 7, 2022):
@anupriya17 Thank you for pointing this out! Looks like we are still using goleak v0.10.0. We should update to the latest release and update to the newer API as suggested.
@MohabMohamed commented on GitHub (May 8, 2022):
I would love to work on this issue.
@hibiken can you please assign it to me?
@MohabMohamed commented on GitHub (May 8, 2022):
Done in #454 , @hibiken please review.
@hibiken commented on GitHub (May 8, 2022):
Thank you @MohabMohamed and @anupriya17 🎉