starred/asynq

Fork 0

mirror of https://github.com/hibiken/asynq.git synced 2026-04-26 07:25:56 +03:00

[GH-ISSUE #456] [FEATURE REQUEST] Is there any way to do some specific action before periodic task enqueue? #208

New issue

Closed

opened 2026-03-02 05:19:38 +03:00 by kerem · 7 comments

kerem commented

2026-03-02 05:19:38 +03:00

Owner

Originally created by @ChihSeanHsu on GitHub (May 8, 2022).
Original GitHub issue: https://github.com/hibiken/asynq/issues/456

Originally assigned to: @hibiken on GitHub.

Is your feature request related to a problem? Please describe.
As title, I'm wondering is there any option or handler before periodic task enqueue?

Describe the solution you'd like
Maybe, we can solve this case just like error-handling

Additional context
IMO, we can implement this function in Enqueue part, not only for periodic task.

Originally created by @ChihSeanHsu on GitHub (May 8, 2022). Original GitHub issue: https://github.com/hibiken/asynq/issues/456 Originally assigned to: @hibiken on GitHub. **Is your feature request related to a problem? Please describe.** As title, I'm wondering is there any option or handler before periodic task enqueue? **Describe the solution you'd like** Maybe, we can solve this case just like [error-handling](https://github.com/hibiken/asynq/wiki/Periodic-Tasks#error-handling) **Additional context** IMO, we can implement this function in Enqueue part, not only for periodic task.

kerem

2026-03-02 05:19:38 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-03-02 05:19:39 +03:00

Author

Owner

@hibiken commented on GitHub (May 9, 2022):

@ChihSeanHsu thank you for creating a feature request.

What kind of action do you need to perform before enqueueing a task? I want to understand the motivation.

@hibiken commented on GitHub (May 9, 2022): @ChihSeanHsu thank you for creating a feature request. What kind of action do you need to perform before enqueueing a task? I want to understand the motivation.

kerem commented

2026-03-02 05:19:39 +03:00

Author

Owner

@ChihSeanHsu commented on GitHub (May 9, 2022):

@hibiken Thanks for your prompt response.
We want to have a metrics to monitor the periodic enqueue count or some other actions (Currently, I have no another idea).
Although, we can just make this metrics by processing task part, but I just wonder is there any pre-action way not post-action.

@ChihSeanHsu commented on GitHub (May 9, 2022): @hibiken Thanks for your prompt response. We want to have a metrics to monitor the periodic enqueue count or some other actions (Currently, I have no another idea). Although, we can just make this metrics by processing task part, but I just wonder is there any pre-action way not post-action.

kerem commented

2026-03-02 05:19:39 +03:00

Author

Owner

@hibiken commented on GitHub (May 10, 2022):

I see. Actually, now that I'm thinking about it, maybe it makes sense to allow users to provide callbacks before and after enqueue happens on Scheduler.

Something like:

type SchedulerOpts struct {
    // PreEnqueueFunc, if provided, is called before a task gets enqueued by Scheduler.
    // The callback function should return quickly to not block the current thread.
    PreEnqueueFunc func(task *Task, opts []Option)

    // PostEnqueueFunc, if provided, is called after a task gets enqueued by Scheduler.
    // The callback function should return quickly to not block the current thread.
    PostEnqueueFunc func(info *TaskInfo, err error)

   // ... other options

   // Deprecated: Use PostEnqueueFunc instead
   ErrorHandlerFunc func(task *Task, opts []Option, err error)
}

@hibiken commented on GitHub (May 10, 2022): I see. Actually, now that I'm thinking about it, maybe it makes sense to allow users to provide callbacks before and after enqueue happens on Scheduler. Something like: ```go type SchedulerOpts struct { // PreEnqueueFunc, if provided, is called before a task gets enqueued by Scheduler. // The callback function should return quickly to not block the current thread. PreEnqueueFunc func(task *Task, opts []Option) // PostEnqueueFunc, if provided, is called after a task gets enqueued by Scheduler. // The callback function should return quickly to not block the current thread. PostEnqueueFunc func(info *TaskInfo, err error) // ... other options // Deprecated: Use PostEnqueueFunc instead ErrorHandlerFunc func(task *Task, opts []Option, err error) }

kerem commented

2026-03-02 05:19:39 +03:00

Author

Owner

@ChihSeanHsu commented on GitHub (May 10, 2022):

@hibiken Great.
Thanks for your help!
What will the road map be about this small feature?
Or can I just submit a PR about it?

@ChihSeanHsu commented on GitHub (May 10, 2022): @hibiken Great. Thanks for your help! What will the road map be about this small feature? Or can I just submit a PR about it?

kerem commented

2026-03-02 05:19:40 +03:00

Author

Owner

@hibiken commented on GitHub (May 10, 2022):

@ChihSeanHsu Feel free to open a PR if you have bandwidth to work on it. Thanks :)

@hibiken commented on GitHub (May 10, 2022): @ChihSeanHsu Feel free to open a PR if you have bandwidth to work on it. Thanks :)

kerem commented

2026-03-02 05:19:40 +03:00

Author

Owner

@ChihSeanHsu commented on GitHub (May 22, 2022):

Hi @hibiken
Here is the PR, and feel free to review it thanks.

@ChihSeanHsu commented on GitHub (May 22, 2022): Hi @hibiken Here is the [PR](https://github.com/hibiken/asynq/pull/476), and feel free to review it thanks.

kerem commented

2026-03-02 05:19:40 +03:00

Author

Owner

@hibiken commented on GitHub (May 27, 2022):

Closed via #476. This feature will be included in the next release. Thank you @ChihSeanHsu !

@hibiken commented on GitHub (May 27, 2022): Closed via #476. This feature will be included in the next release. Thank you @ChihSeanHsu !

kerem referenced this issue

2026-03-02 05:54:30 +03:00

[PR #208] [MERGED] fix: Wait for specified time duration before shutdown #666

kerem referenced this issue

2026-03-07 22:11:53 +03:00

[PR #208] [MERGED] fix: Wait for specified time duration before shutdown #1676

kerem referenced this issue

2026-03-15 20:57:59 +03:00

[PR #208] [MERGED] fix: Wait for specified time duration before shutdown #2687