[PR #972] [CLOSED] fix: mark the client that the scheduler made also as non-shared #1967

New issue

Closed

opened 2026-03-07 22:14:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 22:14:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/972
Author: @mikhail5555
Created: 11/19/2024
Status: ❌ Closed

Base: master ← Head: fix-scheduler-shutdown-error

📝 Commits (1)

5dfa742 mark the client that the scheduler made also as non-shared

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 scheduler.go (+1 -0)

📄 Description

the redisClient that the NewScheduler makes should also be marked as non-shared, otherwise it throws the error

ERROR Failed to close redis client connection: redis connection is shared so the Client can't be closed through asynq

on shutdown.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/972 **Author:** [@mikhail5555](https://github.com/mikhail5555) **Created:** 11/19/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-scheduler-shutdown-error` --- ### 📝 Commits (1) - [`5dfa742`](https://github.com/hibiken/asynq/commit/5dfa74254f572d36af2c61bf6dbc760ed264f3cc) mark the client that the scheduler made also as non-shared ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `scheduler.go` (+1 -0) </details> ### 📄 Description the `redisClient` that the `NewScheduler` makes should also be marked as non-shared, otherwise it throws the error ``` ERROR Failed to close redis client connection: redis connection is shared so the Client can't be closed through asynq ``` on shutdown. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-07 22:14:06 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#1967

No description provided.

Rows
Columns