[PR #927] [MERGED] Run golangci-lint in CI #1933

New issue

Closed

opened 2026-03-07 22:13:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 22:13:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/927
Author: @pior
Created: 10/25/2024
Status: ✅ Merged
Merged: 10/26/2024
Merged by: @kamikazechaser

Base: master ← Head: golangci-lint

📝 Commits (2)

ebe1d6c Setup golangci-lint in CI and local-dev
c17cc47 Fix linting error or locally disable linter

📊 Changes

12 files changed (+50 additions, -29 deletions)

View changed files

📝 .github/workflows/build.yml (+14 -0)
📝 Makefile (+5 -1)
📝 benchmark_test.go (+4 -4)
📝 client.go (+1 -1)
📝 client_test.go (+1 -1)
📝 heartbeat.go (+3 -1)
📝 internal/base/base.go (+13 -13)
📝 internal/rdb/rdb_test.go (+1 -1)
📝 periodic_task_manager.go (+3 -4)
📝 processor_test.go (+1 -1)
📝 scheduler.go (+3 -1)
📝 server_test.go (+1 -1)

📄 Description

Context

We want to run linters in CI

Changes

Add a new Github Action workflow to run the official golangci-lint action, with the latest golangci-lint release
Fix linting errors when possible
Locally disable the failing linter on the deprecated protobuf API (since we should upgrade)

The fix for the context.CancelFunc errors has its own PR since it's a bug: https://github.com/hibiken/asynq/pull/926

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/927 **Author:** [@pior](https://github.com/pior) **Created:** 10/25/2024 **Status:** ✅ Merged **Merged:** 10/26/2024 **Merged by:** [@kamikazechaser](https://github.com/kamikazechaser) **Base:** `master` ← **Head:** `golangci-lint` --- ### 📝 Commits (2) - [`ebe1d6c`](https://github.com/hibiken/asynq/commit/ebe1d6ca3fcc3e565cb63978c95dad45860133c5) Setup golangci-lint in CI and local-dev - [`c17cc47`](https://github.com/hibiken/asynq/commit/c17cc47949d71a9ee74211d24b55663c8d1114e5) Fix linting error or locally disable linter ### 📊 Changes **12 files changed** (+50 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+14 -0) 📝 `Makefile` (+5 -1) 📝 `benchmark_test.go` (+4 -4) 📝 `client.go` (+1 -1) 📝 `client_test.go` (+1 -1) 📝 `heartbeat.go` (+3 -1) 📝 `internal/base/base.go` (+13 -13) 📝 `internal/rdb/rdb_test.go` (+1 -1) 📝 `periodic_task_manager.go` (+3 -4) 📝 `processor_test.go` (+1 -1) 📝 `scheduler.go` (+3 -1) 📝 `server_test.go` (+1 -1) </details> ### 📄 Description ## Context We want to run linters in CI ## Changes - Add a new Github Action workflow to run the official golangci-lint action, with the latest golangci-lint release - Fix linting errors when possible - Locally disable the failing linter on the deprecated protobuf API (since we should upgrade) The fix for the context.CancelFunc errors has its own PR since it's a bug: https://github.com/hibiken/asynq/pull/926 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-07 22:13:56 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#1933

No description provided.

Rows
Columns