[PR #627] [MERGED] (core mod) pkg: bump go-redis -> v9 #1814

New issue

Closed

opened 2026-03-07 22:13:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 22:13:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/627
Author: @kamikazechaser
Created: 3/14/2023
Status: ✅ Merged
Merged: 4/18/2023
Merged by: @hibiken

Base: master ← Head: sohail/bump-redis-pkg

📝 Commits (8)

abdfea8 Update redis/go-redis to v9
53e4ec5 pkg: remove v8 refs
4db3079 fix unit test
5b4f147 tests: restore ignore goleak.IgnoreTopFunction
8682692 completely update Redis package
bccd25b pkg (tools): revert replace directive in go.mod
74ed7ca fix: breaking build below go < 1.18
56cd6a1 (tools & x): revert to v8 version cc777eb

📊 Changes

20 files changed (+117 additions, -235 deletions)

View changed files

📝 asynq.go (+1 -1)
📝 asynq_test.go (+1 -1)
📝 client.go (+1 -1)
📝 go.mod (+4 -5)
📝 go.sum (+20 -133)
📝 inspector.go (+1 -1)
📝 inspector_test.go (+5 -5)
📝 internal/base/base.go (+1 -1)
📝 internal/rdb/inspect.go (+1 -1)
📝 internal/rdb/inspect_test.go (+37 -39)
📝 internal/rdb/rdb.go (+7 -7)
📝 internal/rdb/rdb_test.go (+26 -29)
📝 internal/testbroker/testbroker.go (+1 -1)
📝 internal/testutil/testutil.go (+3 -3)
📝 scheduler.go (+1 -1)
📝 server.go (+1 -1)
📝 server_test.go (+2 -2)
📝 subscriber.go (+1 -1)
📝 tools/go.mod (+1 -1)
📝 tools/go.sum (+2 -1)

📄 Description

This is a replacement PR for #602 and closes #570. It fixes the tests (all tests pass) and removes v8 references form wherever possible.

Modules tools and x still indirectly reference v8. They should be updated once the main asynq package is bumped. I have also removed replace directives that were initially added to this PR ( only useful for local dev) and which were previously also removed in #392.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/627 **Author:** [@kamikazechaser](https://github.com/kamikazechaser) **Created:** 3/14/2023 **Status:** ✅ Merged **Merged:** 4/18/2023 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `sohail/bump-redis-pkg` --- ### 📝 Commits (8) - [`abdfea8`](https://github.com/hibiken/asynq/commit/abdfea8eddc4ccf0f4a3810927f0d9f7a7efd7f2) Update redis/go-redis to v9 - [`53e4ec5`](https://github.com/hibiken/asynq/commit/53e4ec506d2f1a50a942f6bcdb257bc639f91138) pkg: remove v8 refs - [`4db3079`](https://github.com/hibiken/asynq/commit/4db3079c9225078f73114fb9a77908e24a55f14a) fix unit test - [`5b4f147`](https://github.com/hibiken/asynq/commit/5b4f147a63eabd05aa81eeab6d6af74db3ae7af5) tests: restore ignore goleak.IgnoreTopFunction - [`8682692`](https://github.com/hibiken/asynq/commit/8682692e026ce4be150d41327ee9347c1e1d96e6) completely update Redis package - [`bccd25b`](https://github.com/hibiken/asynq/commit/bccd25b657773b91fb1704d5c077686ceb0a2773) pkg (tools): revert replace directive in go.mod - [`74ed7ca`](https://github.com/hibiken/asynq/commit/74ed7ca100a55de53383931e90cd4f7d6d7f7e3a) fix: breaking build below go < 1.18 - [`56cd6a1`](https://github.com/hibiken/asynq/commit/56cd6a12c01ff3ec6444733152571bb05c855516) (tools & x): revert to v8 version cc777eb ### 📊 Changes **20 files changed** (+117 additions, -235 deletions) <details> <summary>View changed files</summary> 📝 `asynq.go` (+1 -1) 📝 `asynq_test.go` (+1 -1) 📝 `client.go` (+1 -1) 📝 `go.mod` (+4 -5) 📝 `go.sum` (+20 -133) 📝 `inspector.go` (+1 -1) 📝 `inspector_test.go` (+5 -5) 📝 `internal/base/base.go` (+1 -1) 📝 `internal/rdb/inspect.go` (+1 -1) 📝 `internal/rdb/inspect_test.go` (+37 -39) 📝 `internal/rdb/rdb.go` (+7 -7) 📝 `internal/rdb/rdb_test.go` (+26 -29) 📝 `internal/testbroker/testbroker.go` (+1 -1) 📝 `internal/testutil/testutil.go` (+3 -3) 📝 `scheduler.go` (+1 -1) 📝 `server.go` (+1 -1) 📝 `server_test.go` (+2 -2) 📝 `subscriber.go` (+1 -1) 📝 `tools/go.mod` (+1 -1) 📝 `tools/go.sum` (+2 -1) </details> ### 📄 Description This is a replacement PR for #602 and closes #570. It fixes the tests (all tests pass) and removes v8 references form wherever possible. Modules `tools` and `x` still indirectly reference v8. They should be updated once the main asynq package is bumped. I have also removed replace directives that were initially added to this PR ( only useful for local dev) and which were previously also removed in #392. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-07 22:13:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#1814

No description provided.

Rows
Columns