mirror of
https://github.com/hibiken/asynq.git
synced 2026-04-26 15:35:55 +03:00
[PR #505] feat: add custom unique key option #1776
Labels
No labels
CLI
bug
designing
documentation
duplicate
enhancement
good first issue
good first issue
help wanted
idea
invalid
investigate
needs-more-info
performance
pr-welcome
pull-request
question
wontfix
work in progress
work in progress
work-around-available
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asynq#1776
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hibiken/asynq/pull/505
Author: @22dm
Created: 6/24/2022
Status: 🔄 Open
Base:
master← Head:custom-unique-key📝 Commits (2)
519985ffeat: add custom unique key option69f4dd7Merge branch 'master' into custom-unique-key📊 Changes
4 files changed (+85 additions, -2 deletions)
View changed files
📝
client.go(+30 -2)📝
client_test.go(+43 -0)📝
inspector.go(+6 -0)📝
internal/base/base.go(+6 -0)📄 Description
When Enqueue Unique Task, allow the user to customize the UniqueKey instead of using Task Payload by default, because the payload may contain things like trace IDs from upstream, and in some scenarios these tasks should still be considered the same task despite the differences in these fields.
The reason for not using task ID is that TTL is needed to avoid some workers quitting abnormally, making it impossible to continue the task.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.