[PR #152] [MERGED] Change internal constructor signatures. #1648

New issue

Closed

opened 2026-03-07 22:11:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 22:11:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/152
Author: @hibiken
Created: 5/17/2020
Status: ✅ Merged
Merged: 5/17/2020
Merged by: @hibiken

Base: master ← Head: misc/constructor

📝 Commits (1)

8080ce1 Change internal constructor signatures.

📊 Changes

11 files changed (+112 additions, -36 deletions)

View changed files

📝 heartbeat.go (+12 -5)
📝 heartbeat_test.go (+12 -2)
📝 processor.go (+2 -2)
📝 processor_test.go (+4 -4)
📝 scheduler.go (+12 -5)
📝 scheduler_test.go (+6 -1)
📝 server.go (+24 -5)
📝 subscriber.go (+10 -4)
📝 subscriber_test.go (+10 -2)
📝 syncer.go (+10 -4)
📝 syncer_test.go (+10 -2)

📄 Description

Created "params" type to avoid positional arguments.
Personally it feels more explicit and reads better.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/152 **Author:** [@hibiken](https://github.com/hibiken) **Created:** 5/17/2020 **Status:** ✅ Merged **Merged:** 5/17/2020 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `master` ← **Head:** `misc/constructor` --- ### 📝 Commits (1) - [`8080ce1`](https://github.com/hibiken/asynq/commit/8080ce12c5914d363cd112dcf51611ed0465dee8) Change internal constructor signatures. ### 📊 Changes **11 files changed** (+112 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `heartbeat.go` (+12 -5) 📝 `heartbeat_test.go` (+12 -2) 📝 `processor.go` (+2 -2) 📝 `processor_test.go` (+4 -4) 📝 `scheduler.go` (+12 -5) 📝 `scheduler_test.go` (+6 -1) 📝 `server.go` (+24 -5) 📝 `subscriber.go` (+10 -4) 📝 `subscriber_test.go` (+10 -2) 📝 `syncer.go` (+10 -4) 📝 `syncer_test.go` (+10 -2) </details> ### 📄 Description Created "params" type to avoid positional arguments. Personally it feels more explicit and reads better. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-07 22:11:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#1648

No description provided.

Rows
Columns