starred/asynq

Fork 0

mirror of https://github.com/hibiken/asynq.git synced 2026-04-25 23:15:51 +03:00

[GH-ISSUE #373] [FEATURE REQUEST] Optional `WAIT` flag for Enqueue #162

New issue

Open

opened 2026-03-02 05:19:14 +03:00 by kerem · 5 comments

kerem commented

2026-03-02 05:19:14 +03:00

Owner

Originally created by @danthegoodman1 on GitHub (Dec 31, 2021).
Original GitHub issue: https://github.com/hibiken/asynq/issues/373

Originally assigned to: @hibiken on GitHub.

I think it would be useful to have the option to use or not use WAIT {some number} with Enqueue such that we can have assurance that we durably wrote to Redis (when not using AOF).

Since Redis can lose writes before syncing to a replica, this is still a conern present without AOF.

Maybe an asynq.Wait(int) would be a parameter that would be passed to the client.Enqueue() function.

Originally created by @danthegoodman1 on GitHub (Dec 31, 2021). Original GitHub issue: https://github.com/hibiken/asynq/issues/373 Originally assigned to: @hibiken on GitHub. I think it would be useful to have the option to use or not use `WAIT {some number}` with Enqueue such that we can have assurance that we durably wrote to Redis (when not using AOF). Since Redis can lose writes before syncing to a replica, this is still a conern present without AOF. Maybe an `asynq.Wait(int)` would be a parameter that would be passed to the `client.Enqueue()` function.

kerem added the

enhancement

help wanted

labels

2026-03-02 05:19:14 +03:00

kerem commented

2026-03-02 05:19:15 +03:00

Author

Owner

@hibiken commented on GitHub (Jan 1, 2022):

@danthegoodman1 Great feature request.

I believe synchronous replication is needed in some use cases and may be a common need.
Let me do a little bit more research around this to come up with a suggestion.

Any suggestion on the API is welcome!

@hibiken commented on GitHub (Jan 1, 2022): @danthegoodman1 Great feature request. I believe synchronous replication is needed in some use cases and may be a common need. Let me do a little bit more research around this to come up with a suggestion. Any suggestion on the API is welcome!

kerem commented

2026-03-02 05:19:15 +03:00

Author

Owner

@vishjain commented on GitHub (Jul 8, 2022):

@hibiken Can I submit a PR for this? Thanks!

@vishjain commented on GitHub (Jul 8, 2022): @hibiken Can I submit a PR for this? Thanks!

kerem commented

2026-03-02 05:19:15 +03:00

Author

Owner

@danthegoodman1 commented on GitHub (Oct 4, 2023):

bumping, this would be really helpful as temporal overhead is inappropriate for some use cases

@danthegoodman1 commented on GitHub (Oct 4, 2023): bumping, this would be really helpful as temporal overhead is inappropriate for some use cases

kerem commented

2026-03-02 05:19:15 +03:00

Author

Owner

@kamikazechaser commented on GitHub (Oct 5, 2023):

Possibly needs a refactor for https://github.com/hibiken/asynq/blob/master/internal/rdb/rdb.go#L152..

numreplicas and timeout metadata need to be added to base.TaskMessage.

@kamikazechaser commented on GitHub (Oct 5, 2023): Possibly needs a refactor for https://github.com/hibiken/asynq/blob/master/internal/rdb/rdb.go#L152.. `numreplicas` and `timeout` metadata need to be added to `base.TaskMessage`.

kerem commented

2026-03-02 05:19:15 +03:00

Author

Owner

@danthegoodman1 commented on GitHub (Oct 5, 2023):

For those wondering, in the meantime you can just either add AOF (for single host deployments) or you can use a service like upstash redis/aws memorydb that natively has both persistence and HA.

Edit: AOF might work if only a single host in a cluster gets it too, but I have never tested or seen talk of that failover pattern (but I assume based on async replication it would sync it across the cluster)

@danthegoodman1 commented on GitHub (Oct 5, 2023): For those wondering, in the meantime you can just either add AOF (for single host deployments) or you can use a service like upstash redis/aws memorydb that natively has both persistence and HA. Edit: AOF might work if only a single host in a cluster gets it too, but I have never tested or seen talk of that failover pattern (but I assume based on async replication it would sync it across the cluster)

kerem referenced this issue

2026-03-02 05:54:24 +03:00

[PR #162] [CLOSED] WIP: Fix Message forwarding #644

kerem referenced this issue

2026-03-07 22:11:45 +03:00

[PR #162] [CLOSED] WIP: Fix Message forwarding #1652

kerem referenced this issue

2026-03-15 20:56:38 +03:00

[PR #162] [CLOSED] WIP: Fix Message forwarding #2662