[PR #82] [MERGED] Stop using uint to mean non-negative quantities #1604

New issue

Closed

opened 2026-03-07 22:11:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 22:11:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hibiken/asynq/pull/82
Author: @hibiken
Created: 2/13/2020
Status: ✅ Merged
Merged: 2/13/2020
Merged by: @hibiken

Base: next ← Head: api/priority-int

📝 Commits (1)

7020569 Use int as priority value type.

📊 Changes

15 files changed (+84 additions, -70 deletions)

View changed files

📝 README.md (+2 -3)
📝 background.go (+15 -8)
📝 background_test.go (+19 -19)
📝 benchmark_test.go (+1 -1)
📝 heartbeat_test.go (+2 -2)
📝 internal/base/base.go (+2 -2)
📝 internal/base/base_test.go (+1 -1)
📝 internal/rdb/inspect.go (+2 -2)
📝 internal/rdb/inspect_test.go (+12 -12)
📝 internal/rdb/rdb_test.go (+1 -1)
📝 processor.go (+8 -8)
📝 processor_test.go (+4 -4)
📝 scheduler.go (+1 -1)
📝 tools/asynqmon/cmd/ls.go (+12 -4)
📝 tools/asynqmon/cmd/ps.go (+2 -2)

📄 Description

Do not use unsigned int for merely non-negative quantities as it complicates arithmetic.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hibiken/asynq/pull/82 **Author:** [@hibiken](https://github.com/hibiken) **Created:** 2/13/2020 **Status:** ✅ Merged **Merged:** 2/13/2020 **Merged by:** [@hibiken](https://github.com/hibiken) **Base:** `next` ← **Head:** `api/priority-int` --- ### 📝 Commits (1) - [`7020569`](https://github.com/hibiken/asynq/commit/702056991d33eb4daa62a8b3d5ebbe736d17bae0) Use int as priority value type. ### 📊 Changes **15 files changed** (+84 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -3) 📝 `background.go` (+15 -8) 📝 `background_test.go` (+19 -19) 📝 `benchmark_test.go` (+1 -1) 📝 `heartbeat_test.go` (+2 -2) 📝 `internal/base/base.go` (+2 -2) 📝 `internal/base/base_test.go` (+1 -1) 📝 `internal/rdb/inspect.go` (+2 -2) 📝 `internal/rdb/inspect_test.go` (+12 -12) 📝 `internal/rdb/rdb_test.go` (+1 -1) 📝 `processor.go` (+8 -8) 📝 `processor_test.go` (+4 -4) 📝 `scheduler.go` (+1 -1) 📝 `tools/asynqmon/cmd/ls.go` (+12 -4) 📝 `tools/asynqmon/cmd/ps.go` (+2 -2) </details> ### 📄 Description Do not use unsigned int for merely non-negative quantities as it complicates arithmetic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-07 22:11:31 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/asynq#1604

No description provided.

Rows
Columns