mirror of
https://github.com/hibiken/asynq.git
synced 2026-04-26 15:35:55 +03:00
[GH-ISSUE #626] Need maintainers? #1321
Labels
No labels
CLI
bug
designing
documentation
duplicate
enhancement
good first issue
good first issue
help wanted
idea
invalid
investigate
needs-more-info
performance
pr-welcome
pull-request
question
wontfix
work in progress
work in progress
work-around-available
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asynq#1321
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ilkerkorkut on GitHub (Mar 14, 2023).
Original GitHub issue: https://github.com/hibiken/asynq/issues/626
Originally assigned to: @hibiken on GitHub.
I've noticed issues and PR's piling up. @hibiken do you need help maintaining this?
@kamikazechaser commented on GitHub (Mar 14, 2023):
Yeah noticed this too :(
Some PRs look really important.
@hibiken commented on GitHub (Mar 17, 2023):
Yes, it'd be great if I can get some help with reviewing PRs and managing releases. I don't have enough bandwidth to focus on this project recently.
@ioannidesalex commented on GitHub (Mar 31, 2023):
Even though I don’t have much free time, I can also assist with maintnenance. It’s a great project and it has to keep going.
@ibukunoluwayomi commented on GitHub (Apr 7, 2023):
Happy to assist with maintenance too. I've loved using Asynq. Would be great to give back.
@ibukunoluwayomi commented on GitHub (Apr 7, 2023):
I'm a fan of a mono repo in this case too.
@vishrutkohli commented on GitHub (Apr 10, 2023):
i can help too .
@sjiekak commented on GitHub (Apr 20, 2023):
I've never contributed to this project but used celery in python, implemented own redis and rabbitmq distributed task queue for my job. I also see few quality insurance tools could help (linters like golangci, package manager like renovate, etc...).
@ilkerkorkut commented on GitHub (Apr 28, 2023):
We may create a nice community on top this project. I don't have enough time to create discord channel etc. Can somebody be a volunteer via taking an action for coming together? May be we can consider about forking this project and contribute on on it. Any other ideas?
@ioannidesalex commented on GitHub (Apr 28, 2023):
I can do a Discord server if we gather enough interest.
@acaloiaro commented on GitHub (Apr 28, 2023):
I'm happy to help review PRs and issues.
But before anyone can do anything of substance on this repo I think contributors should seek @hibiken's blessing to become official maintainers with repository permissions. Otherwise, the only option to contribute without Ken becoming a bottleneck is forking the repo and organizing a group of contributors around a new repository. That can be seen as a hostile act without the original author's blessing.
@hibiken When you have some time to think about this, it would be helpful to hear how you'd like the maintenance of this project to move forward
hibiken/asynq? Or would you like the mental distance of moving it to an open source org likeasynq(do you control this organization? If not, maybego-asynq, which is available)?asynqfamiliarity to guide the project in a good direction?I do have time to help the project get organized around a new group of contributors and set some priorities. But I don't have a lot of
asynqexperience, and I can only imagine there's someone better suited to stewarding this project from a trust and knowledge standpoint.@ioannidesalex commented on GitHub (Apr 28, 2023):
I completely agree that we should talk with @hibiken . No hostile acts at all. We shall do whatever is best for the project, following his feedback, recommendations and blessings.
@benjaminclauss commented on GitHub (Jun 30, 2023):
looks like conversation on this issue has slowed down
I would be very interested in helping with maintaining this project.
@benjaminclauss commented on GitHub (Jun 30, 2023):
Would collaborators on this thread be opposed to waiting the entirety of July 2023 for an update? If others have input as to a more appropriate duration, feel free to comment.
If no update is received, I would be interested in creating an organization to manage a fork.
@ilkerkorkut commented on GitHub (Jul 3, 2023):
Actually, @hibiken didn't response to here about forking. I think most of contributors waiting for his considerations.
@benjaminclauss commented on GitHub (Jul 3, 2023):
Any modifications to a fork could be pushed upstream, right?
@acaloiaro commented on GitHub (Jul 3, 2023):
In the interest of advancing currently pending issues/PRs, I went ahead and forked this project into https://github.com/go-asynq/asynq
To be clear, my intention is not to become a permanent maintainer of this project, or for
go-asynq/asynqto become an "official" fork ofasynq, unless that is @hibiken's desire. I don't have enough familiarity with the project to be anything like a lead maintainer, and I also don't have the desire to be that.My hope is that this will be temporary, and @hibiken can declare their desire for
asynq's future when they have the time to do so. Ideally, with any changes that happen ongo-asynq/asynqbeing merged back intohibiken/asynqat that time.If anyone wants to help facilitate development on
go-asynq/asynq, I'm happy to add official contributors there. Since there are no current users ofgo-asynq/asynq, there is no risk of a supply chain attacks through the fork. Open an issue if you're interested in maintaining: https://github.com/go-asynq/asynq/issuesAs for communications, I don't see a reason for a Discord, as the project already has an official Gitter: https://gitter.im/go-asynq/community
If this fork gains momentum, I'm happy to do my best with PR/Issue review, and will set up a release system, per @hibiken's comment here: https://github.com/hibiken/asynq/issues/626#issuecomment-1473040642. That way, if and hopefully when the fork merges back into this repository, Ken will get at least one thing that they hoped for.
So this is more or less a call for maintainers who can do the work of (at least temporarily) maintaining a project. If that's you, head over to the fork and bring your pet issues/PRs: https://github.com/go-asynq/asynq
@hibiken commented on GitHub (Jul 3, 2023):
Sorry that I haven't responded to this thread for a while.
@acaloiaro and others
Thank you so much for being very respectful and expressing interests in maintaining this project.
I think maintaining a separate fork in conjunction with the original project may cause more headaches in the long-run (I may reject some features that were added to the forked project or vice-versa, then the two projects will diverge). so my recommendation is to maintain this repository (both for my selfish reason + maintainability reason).
I have become the bottle neck in recent months and I will try my best to start reviewing incoming issues/PRs at least once a week. We do have quite a lengthy backlog of issues/PRs so I'll also try to go through them at much slower pace (so if you think there's an urgent/important issue/PR, please add a comment).
That being said, I have other higher priority responsibilities -- being an employee, a dad, a husband, etc, and I'll have limited bandwidth to work on this project Hopefully in the future, I can find a few maintainers, so we can increase the bus-factor for the project.
Lastly, if you are using this package for business, please consider sponsoring -- it really helps to justify my time spent on this project.
Thanks!
@benjaminclauss commented on GitHub (Jul 4, 2023):
sounds like this issue can be closed then?
I would be interested but will discuss in Gitter.
@kamikazechaser commented on GitHub (Jul 4, 2023):
Agree with @hibiken. Aside from outdated dependencies, the project is pretty stable and has enough features to cover most worker queue requirements.
That being said, I am open to reviewing/merging any dependency upgrades/security fixes/critical bug fixes.
@acaloiaro commented on GitHub (Jul 4, 2023):
Awesome, thank you @hibiken! I'll go ahead and shut that org/fork down.
@benjaminclauss commented on GitHub (Jul 4, 2023):
I would be very interested in supporting backends other than Redis (i.e. Mongo).
https://github.com/hibiken/asynq/issues/173