mirror of
https://github.com/hibiken/asynq.git
synced 2026-04-26 07:25:56 +03:00
[GH-ISSUE #292] [BUG] message always pending #116
Labels
No labels
CLI
bug
designing
documentation
duplicate
enhancement
good first issue
good first issue
help wanted
idea
invalid
investigate
needs-more-info
performance
pr-welcome
pull-request
question
wontfix
work in progress
work in progress
work-around-available
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asynq#116
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @moulo1982 on GitHub (Jul 14, 2021).
Original GitHub issue: https://github.com/hibiken/asynq/issues/292
Originally assigned to: @hibiken on GitHub.
Describe the bug
message always pending
To Reproduce
Steps to reproduce the behavior (Code snippets if applicable):
Queue Name is “CamelCase”,Enqueue method use QueueOpting (
// Queue name is case-insensitive and the lowercased version is used.
func Queue(qname string) Option {
return queueOption(strings.ToLower(qname))
}
), but Server “asynq.Config”‘s Queues not “ToLower”。so, message always pending。
Sorry, My English is very pool。
@hibiken commented on GitHub (Jul 14, 2021):
@moulo1982 Thank you so much for spotting this bug!
Now that I'm thinking about this, I think it doesn't make much sense to make queue names case-insensitive?
Do you think we should just use the queue name provided as is (without normalize it to lowercase)?
What do you think? /cc @crossworth
@crossworth commented on GitHub (Jul 14, 2021):
I think we can use as provided, I don't see any problem with it, simple is better.
@moulo1982 commented on GitHub (Jul 15, 2021):
I think it's good