mirror of
https://github.com/asciinema/asciinema.git
synced 2026-04-25 16:05:52 +03:00
[PR #80] [MERGED] New asciicast file format + saving/replaying locally #991
Labels
No labels
bug
compatibility
feature request
fit for beginners
help wanted
hosting
idea
improvement
packaging
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asciinema#991
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/asciinema/asciinema/pull/80
Author: @ku1ik
Created: 2/24/2015
Status: ✅ Merged
Merged: 3/2/2015
Merged by: @ku1ik
Base:
master← Head:decoupling📝 Commits (10+)
f441986New asciicast file format, ability to save asciicasts locallyaac8ceaAdd command for uploading locally saved asciicasts224fc8cInstruct user on how to retry upload when rec fails to do it83828d7Better filename for tmp asciicast fileaa493e5Documentrec,playanduploadcommandsd8f84d9Document asciicast file format2ec34adWords17cadf6Close tmp file instead of removing itc5d3bbeWords0e0f333Don't reinvent "marshal string to JSON" wheel📊 Changes
17 files changed (+602 additions, -206 deletions)
View changed files
📝
README.md(+38 -9)📝
api/api.go(+17 -67)📝
api/http.go(+8 -6)➕
asciicast/asciicast.go(+75 -0)➕
asciicast/frame.go(+35 -0)➕
asciicast/frame_test.go(+80 -0)➕
asciicast/player.go(+34 -0)➕
asciicast/recorder.go(+62 -0)➕
asciicast/stream.go(+51 -0)➕
commands/play.go(+35 -0)📝
commands/rec.go(+37 -74)📝
commands/rec_test.go(+7 -46)➕
commands/upload.go(+38 -0)➕
doc/asciicast-v1.md(+62 -0)📝
main.go(+6 -2)📝
terminal/terminal.go(+16 -1)📝
terminal/terminal_test.go(+1 -1)📄 Description
This one allows recording to a local file with
asciinema rec demo.json, in-terminal replay withasciinema play demo.json, and upload to asciinema.org withasciinema upload demo.json.asciinema recwithout filename argument works as before - uploads to asciinema.org after asking for confirmation. However, asciicast is saved to a tmp file before uploading, allowing user to retry upload later withasciinema upload /tmp/path/to/asciicast.jsonin case of upload error (like network connection issue etc).🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.