mirror of
https://github.com/asciinema/asciinema.git
synced 2026-04-25 16:05:52 +03:00
[GH-ISSUE #633] Update MSRV notice in README #941
Labels
No labels
bug
compatibility
feature request
fit for beginners
help wanted
hosting
idea
improvement
packaging
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asciinema#941
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @non-descriptive on GitHub (May 22, 2024).
Original GitHub issue: https://github.com/asciinema/asciinema/issues/633
I've attempted to install the most recent version of code via cargo and it cried me
Which means my compiler is outdated to build it. So minimal supported rust version should be at least 1.78, due to
axum.@ku1ik commented on GitHub (May 22, 2024):
Weird, works for me:
Builds in both debug and release modes.
What's interesting is your error message mentions axum 0.7.5, while Cargo.lock specifies 0.7.4.
@non-descriptive commented on GitHub (May 22, 2024):
Did like README said -
cargo install --git https://github.com/asciinema/asciinema, not justcargo buildon whatever branch you were. On windows as you can see it's a yields a bit differently and still at least downloadsaxum 0.7.5. No idea where it came from. Could it be because default branch isdevelop?cargo treeshown only0.7.4.The first attempt was on Linux on 1.76 version methinks.
Just
cargo buildondeveloptook me to the point wheretermionfailed to build but it's Windows stuff, not compiler version issue.Also by default I think it doesn't respect lock file unless
--lockedpassed to theinstall. Anyway it should be mentioned in README then.@ku1ik commented on GitHub (May 22, 2024):
Interesting! I assumed
cargo install --git ...respects Cargo.lock just ascargo build, but apparently it doesn't. That would explain why it wants pull newer axum or clap_lex. I'll investigate this further, but probably mentioning--lockedflag in the README is a good idea.