[PR #643] [MERGED] fix(reqwest): use rustls-tls-native-roots to profite OS level custom CA certs #557

New issue

Closed

opened 2026-02-25 20:34:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:34:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/643
Author: @hydezhao
Created: 7/19/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @ku1ik

Base: develop ← Head: feat/default-tls

📝 Commits (2)

c4d9ed2 fix(reqwest): add default-tls feature to reqwest
fbc8279 use rustls-tls-native-roots instead

📊 Changes

2 files changed (+53 additions, -9 deletions)

View changed files

📝 Cargo.lock (+52 -8)
📝 Cargo.toml (+1 -1)

📄 Description

Add add rustls-tls-native-roots feature to reqwest so that the binary can use CA certificates from OS's keystore.

It solves the problem that we cannot upload cast to a self-hosted server with a private CA certificate.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/643 **Author:** [@hydezhao](https://github.com/hydezhao) **Created:** 7/19/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `feat/default-tls` --- ### 📝 Commits (2) - [`c4d9ed2`](https://github.com/asciinema/asciinema/commit/c4d9ed2d621d4be5c2aa32036e551d6879b7b2d1) fix(reqwest): add default-tls feature to reqwest - [`fbc8279`](https://github.com/asciinema/asciinema/commit/fbc8279fd11e6e5220f5d6c73251272181a70b83) use rustls-tls-native-roots instead ### 📊 Changes **2 files changed** (+53 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+52 -8) 📝 `Cargo.toml` (+1 -1) </details> ### 📄 Description Add add `rustls-tls-native-roots` feature to reqwest so that the binary can use CA certificates from OS's keystore. It solves the problem that we cannot upload cast to a self-hosted server with a private CA certificate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>