[PR #621] [CLOSED] add upload-rust-binary-action to upload build results #543

New issue

Closed

opened 2026-02-25 20:34:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:34:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/621
Author: @shawn111
Created: 2/18/2024
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (1)

6ea5ca8 add upload-rust-binary-action to upload build results

📊 Changes

2 files changed (+38 additions, -0 deletions)

View changed files

➕ .github/workflows/release.yml (+34 -0)
📝 CHANGELOG.md (+4 -0)

📄 Description

It's so great to see asciinema switch to Rust.
static binary is much easy to install.

Do you consider to enable upload-rust-binary-action to upload build release?

I just copy the example from https://github.com/taiki-e/upload-rust-binary-action
It supports cross-build.

Currently we just can cargo install.

cargo install --git https://github.com/asciinema/asciinema ## still need local build

I wish cargo binstall could work. https://github.com/cargo-bins/cargo-binstall

cargo binstall asciinema ## directly download binaries.

Here is my test build action: https://github.com/shawn111/asciinema/actions/runs/7950061837

Release binares:
https://github.com/shawn111/asciinema/releases/download/v0.0.1-alpha/asciinema-x86_64-unknown-linux-gnu.tar.gz

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/621 **Author:** [@shawn111](https://github.com/shawn111) **Created:** 2/18/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`6ea5ca8`](https://github.com/asciinema/asciinema/commit/6ea5ca8297c924f20c5ddbd9c0015a09894691f0) add upload-rust-binary-action to upload build results ### 📊 Changes **2 files changed** (+38 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/release.yml` (+34 -0) 📝 `CHANGELOG.md` (+4 -0) </details> ### 📄 Description It's so great to see asciinema switch to Rust. static binary is much easy to install. Do you consider to enable upload-rust-binary-action to upload build release? I just copy the example from https://github.com/taiki-e/upload-rust-binary-action It supports cross-build. Currently we just can cargo install. ``` cargo install --git https://github.com/asciinema/asciinema ## still need local build ``` I wish cargo binstall could work. https://github.com/cargo-bins/cargo-binstall ``` cargo binstall asciinema ## directly download binaries. ``` Here is my test build action: https://github.com/shawn111/asciinema/actions/runs/7950061837 Release binares: https://github.com/shawn111/asciinema/releases/download/v0.0.1-alpha/asciinema-x86_64-unknown-linux-gnu.tar.gz --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>