[PR #601] [MERGED] Replace mio with select in the recorder, add signal handling #532

New issue

Closed

opened 2026-02-25 20:34:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:34:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/601
Author: @ku1ik
Created: 1/6/2024
Status: ✅ Merged
Merged: 1/8/2024
Merged by: @ku1ik

Base: develop ← Head: rec-pselect

📝 Commits (6)

a29aa76 Replace mio with pselect in the recorder
6441eeb Fix infinite loop during recording on macOS
aaad9ec Fix another infinite loop case
cad9b2e Remove mio
3ac8888 Implement signal handling during recording session
2a17050 Use aliased Result

📊 Changes

4 files changed (+171 additions, -166 deletions)

View changed files

📝 Cargo.lock (+0 -14)
📝 Cargo.toml (+1 -3)
📝 src/pty.rs (+158 -136)
📝 src/tty.rs (+12 -13)

📄 Description

This fixes recording on macOS, where mio can't poll /dev/tty via kqueue.

Fixes #598

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/601 **Author:** [@ku1ik](https://github.com/ku1ik) **Created:** 1/6/2024 **Status:** ✅ Merged **Merged:** 1/8/2024 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `rec-pselect` --- ### 📝 Commits (6) - [`a29aa76`](https://github.com/asciinema/asciinema/commit/a29aa7665f0d61ff71400d3fd617d7b78df79352) Replace mio with pselect in the recorder - [`6441eeb`](https://github.com/asciinema/asciinema/commit/6441eeb165b2fa7a30924b1dc7916da9630ced8e) Fix infinite loop during recording on macOS - [`aaad9ec`](https://github.com/asciinema/asciinema/commit/aaad9ecec2e7dccb183a589eafe9199a4b570b58) Fix another infinite loop case - [`cad9b2e`](https://github.com/asciinema/asciinema/commit/cad9b2e2916da4c5187b2a0f82300ca8f6aa210c) Remove mio - [`3ac8888`](https://github.com/asciinema/asciinema/commit/3ac8888cd81d02796ff1902fa17924d862670af2) Implement signal handling during recording session - [`2a17050`](https://github.com/asciinema/asciinema/commit/2a170509a85b33636a1d8b9b27719136fd2c451d) Use aliased Result ### 📊 Changes **4 files changed** (+171 additions, -166 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -14) 📝 `Cargo.toml` (+1 -3) 📝 `src/pty.rs` (+158 -136) 📝 `src/tty.rs` (+12 -13) </details> ### 📄 Description This fixes recording on macOS, where mio can't poll /dev/tty via kqueue. Fixes #598 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>