[PR #453] [MERGED] Improved handling of named pipes (FIFO) #463

Closed
opened 2026-02-25 20:33:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/453
Author: @ku1ik
Created: 12/5/2021
Status: Merged
Merged: 2/15/2022
Merged by: @ku1ik

Base: developHead: feature/fifo-reopen


📝 Commits (2)

  • 62d77dc Automatically reopen named pipe (FIFO) and resume writing upon BrokenPipeError
  • d16c2ab Ignore mypy's check for None in hot code path

📊 Changes

5 files changed (+113 additions, -42 deletions)

View changed files

📝 asciinema/asciicast/raw.py (+14 -18)
📝 asciinema/asciicast/v2.py (+28 -20)
📝 asciinema/async_worker.py (+5 -0)
asciinema/file_writer.py (+43 -0)
📝 asciinema/recorder.py (+23 -4)

📄 Description

Automatically reopen named pipe (FIFO) and resume writing upon BrokenPipeError.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/453 **Author:** [@ku1ik](https://github.com/ku1ik) **Created:** 12/5/2021 **Status:** ✅ Merged **Merged:** 2/15/2022 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `feature/fifo-reopen` --- ### 📝 Commits (2) - [`62d77dc`](https://github.com/asciinema/asciinema/commit/62d77dc9fb8907cd0bb98c0cbe47484a236b04d6) Automatically reopen named pipe (FIFO) and resume writing upon BrokenPipeError - [`d16c2ab`](https://github.com/asciinema/asciinema/commit/d16c2abf2517e3977861fed7a7b63bf3e8674a71) Ignore mypy's check for None in hot code path ### 📊 Changes **5 files changed** (+113 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/asciicast/raw.py` (+14 -18) 📝 `asciinema/asciicast/v2.py` (+28 -20) 📝 `asciinema/async_worker.py` (+5 -0) ➕ `asciinema/file_writer.py` (+43 -0) 📝 `asciinema/recorder.py` (+23 -4) </details> ### 📄 Description Automatically reopen named pipe (FIFO) and resume writing upon BrokenPipeError. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 20:33:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asciinema#463
No description provided.