[PR #368] [CLOSED] Check playback size can fit in terminal #442

New issue

Closed

opened 2026-02-25 20:33:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:33:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/368
Author: @geisler
Created: 9/4/2019
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (2)

c4ce21e Check playback size can fit in terminal
4806723 Update warning message

📊 Changes

3 files changed (+15 additions, -0 deletions)

View changed files

📝 asciinema/asciicast/v1.py (+3 -0)
📝 asciinema/asciicast/v2.py (+3 -0)
📝 asciinema/commands/play.py (+9 -0)

📄 Description

Before playing a recorded file, check that the terminal that is running
the playback is at least as large as the recorded content. This will
allow all the escape characters that change the location on the screen
to go to a legal spot and, therefore, everything should display
properly.

I've chosen to warn for a smaller size instead of causing an error in
case the playback doesn't use escape codes that are too large, but one
could argue that an error is legitimate here, too.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/368 **Author:** [@geisler](https://github.com/geisler) **Created:** 9/4/2019 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (2) - [`c4ce21e`](https://github.com/asciinema/asciinema/commit/c4ce21eaa0cd9a52af06bfa6d154794e84adb9e3) Check playback size can fit in terminal - [`4806723`](https://github.com/asciinema/asciinema/commit/48067231f2675b91c7c22fa282e0a19760b52f32) Update warning message ### 📊 Changes **3 files changed** (+15 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/asciicast/v1.py` (+3 -0) 📝 `asciinema/asciicast/v2.py` (+3 -0) 📝 `asciinema/commands/play.py` (+9 -0) </details> ### 📄 Description Before playing a recorded file, check that the terminal that is running the playback is at least as large as the recorded content. This will allow all the escape characters that change the location on the screen to go to a legal spot and, therefore, everything should display properly. I've chosen to warn for a smaller size instead of causing an error in case the playback doesn't use escape codes that are too large, but one could argue that an error is legitimate here, too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>