[PR #187] [MERGED] adding support to loading API token from an environment variable #405

New issue

Closed

opened 2026-02-25 20:33:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:33:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/187
Author: @samdmarshall
Created: 12/28/2016
Status: ✅ Merged
Merged: 1/28/2017
Merged by: @ku1ik

Base: master ← Head: token-environment-variable

📝 Commits (4)

0919339 adding support to loading API token from an environment variable to remove secrets from config file
85ce06b updating based on requested code-review changes
86289b2 fixing typo!
6e76e8e correcting code logic

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 asciinema/config.py (+2 -2)

📄 Description

This addresses #185, by adding a new fallback method of an environment variable named ASCIINEMA_TOKEN to store the user's API token so that sensitive information doesn't have to be kept in plaintext on disk.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/187 **Author:** [@samdmarshall](https://github.com/samdmarshall) **Created:** 12/28/2016 **Status:** ✅ Merged **Merged:** 1/28/2017 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `master` ← **Head:** `token-environment-variable` --- ### 📝 Commits (4) - [`0919339`](https://github.com/asciinema/asciinema/commit/0919339caf6fa896deb620e8b4f4d06b3d29efab) adding support to loading API token from an environment variable to remove secrets from config file - [`85ce06b`](https://github.com/asciinema/asciinema/commit/85ce06bc05b9e4ddfebb0b77072a2aef6bfaac4d) updating based on requested code-review changes - [`86289b2`](https://github.com/asciinema/asciinema/commit/86289b2d66c8bb2f6910887d025eacce362b1ef3) fixing typo! - [`6e76e8e`](https://github.com/asciinema/asciinema/commit/6e76e8e2e11d5f434c526e8d77e3d180073e6507) correcting code logic ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/config.py` (+2 -2) </details> ### 📄 Description This addresses #185, by adding a new fallback method of an environment variable named `ASCIINEMA_TOKEN` to store the user's API token so that sensitive information doesn't have to be kept in plaintext on disk. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>