[PR #156] [MERGED] Changed max-wait parameter type to float64 #394

New issue

Closed

opened 2026-02-25 20:33:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:33:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/156
Author: @laughedelic
Created: 5/15/2016
Status: ✅ Merged
Merged: 5/18/2016
Merged by: @ku1ik

Base: master ← Head: fractional-max-wait-time

📝 Commits (1)

7b5223f Changed max-wait parameter type to float64

📊 Changes

9 files changed (+27 additions, -27 deletions)

View changed files

📝 asciicast/player.go (+4 -4)
📝 asciicast/recorder.go (+2 -2)
📝 asciicast/stream.go (+2 -2)
📝 commands/play.go (+1 -1)
📝 commands/rec.go (+1 -1)
📝 commands/rec_test.go (+1 -1)
📝 main.go (+6 -6)
📝 util/cfg.go (+4 -4)
📝 util/cfg_test.go (+6 -6)

📄 Description

Nothing sophisticated, just changed the type in all places. I'm not proficient in Go, so excuse me if I did something stupid. Possible improvements:

indicate this change in the docs explicitly
check that the input parameter is positive and print an error otherwise

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/156 **Author:** [@laughedelic](https://github.com/laughedelic) **Created:** 5/15/2016 **Status:** ✅ Merged **Merged:** 5/18/2016 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `master` ← **Head:** `fractional-max-wait-time` --- ### 📝 Commits (1) - [`7b5223f`](https://github.com/asciinema/asciinema/commit/7b5223f5c1192be8bb1a831f932df472b877adc6) Changed max-wait parameter type to float64 ### 📊 Changes **9 files changed** (+27 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `asciicast/player.go` (+4 -4) 📝 `asciicast/recorder.go` (+2 -2) 📝 `asciicast/stream.go` (+2 -2) 📝 `commands/play.go` (+1 -1) 📝 `commands/rec.go` (+1 -1) 📝 `commands/rec_test.go` (+1 -1) 📝 `main.go` (+6 -6) 📝 `util/cfg.go` (+4 -4) 📝 `util/cfg_test.go` (+6 -6) </details> ### 📄 Description Nothing sophisticated, just changed the type in all places. I'm not proficient in Go, so excuse me if I did something stupid. Possible improvements: - indicate this change in the docs explicitly - check that the input parameter is positive and print an error otherwise --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>