[GH-ISSUE #613] Recording wont exit when using P10k's instant prompt

kerem commented

2026-02-25 20:33:19 +03:00

Owner

Originally created by @Pytness on GitHub (Feb 8, 2024).
Original GitHub issue: https://github.com/asciinema/asciinema/issues/613

Describe the bug
asciinema rec wont terminate when exiting zsh shell if using p10k-instant-prompt.

To Reproduce
Steps to reproduce the behavior:

ascinema rec -c "zsh"
...
exit
asciinema keeps recording

Expected behavior
Stop recording

Versions:

OS: Ubuntu 22.04
asciinema cli: asciinema 3.0.0-beta.2

Originally created by @Pytness on GitHub (Feb 8, 2024). Original GitHub issue: https://github.com/asciinema/asciinema/issues/613 **Describe the bug** asciinema rec wont terminate when exiting zsh shell if using p10k-instant-prompt. **To Reproduce** Steps to reproduce the behavior: 1. ascinema rec -c "zsh" 2. ... 3. exit 4. asciinema keeps recording **Expected behavior** Stop recording **Versions:** - OS: Ubuntu 22.04 - asciinema cli: asciinema 3.0.0-beta.2

kerem closed this issue

2026-02-25 20:33:19 +03:00

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 8, 2024):

Hmm, probably a deadlock.

What happens when you record with -c bash and launch zsh from bash manually?

@ku1ik commented on GitHub (Feb 8, 2024): Hmm, probably a deadlock. What happens when you record with `-c bash` and launch `zsh` from bash manually?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 8, 2024):

It hangs after exiting bash.

Here is a recording i made with a great tool i found:

@Pytness commented on GitHub (Feb 8, 2024): It hangs after exiting bash. Here is a recording i made with a great tool i found: [![asciicast](https://asciinema.org/a/GlpFdYWUjnXS9buNTCxbIoQQm.svg)](https://asciinema.org/a/GlpFdYWUjnXS9buNTCxbIoQQm)

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@moritzdietz commented on GitHub (Feb 8, 2024):

Just tried to reproduce it – I have zsh, p10k and instant prompt enabled on my Linux Mint x86_64 PC and I wasn't able to. It worked just fine.

Out of curiosity, are you sure you have only one installation of asciinema on your machine? Because the version you specified yells at you for saying where you want to store the recording. Can it be that you have both the rust + python version available on your path and Bash and ZSH get it mixed up?

@moritzdietz commented on GitHub (Feb 8, 2024): Just tried to reproduce it – I have zsh, p10k and instant prompt enabled on my Linux Mint x86_64 PC and I wasn't able to. It worked just fine. Out of curiosity, are you sure you have only one installation of asciinema on your machine? Because the version you specified yells at you for saying where you want to store the recording. Can it be that you have both the rust + python version available on your path and Bash and ZSH get it mixed up?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 9, 2024):

I dont think so. Its a fresh install through cargo install --git ... and whereis outputs the expected .cargo/bin.
By yelling you mean ::: Recording session started, writing to test.cast?

To be clear, I dont see the problem when I comment out the lines sourcing the instant prompt script. Could be something related? I will try using a newer version, maybe it is just outdated.

@Pytness commented on GitHub (Feb 9, 2024): I dont think so. Its a fresh install through `cargo install --git ...` and `whereis` outputs the expected `.cargo/bin`. By yelling you mean `::: Recording session started, writing to test.cast`? To be clear, I dont see the problem when I comment out the lines sourcing the instant prompt script. Could be something related? I will try using a newer version, maybe it is just outdated.

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 9, 2024):

You can try latest develop, yeah.

Btw, what terminal application do you use?

@ku1ik commented on GitHub (Feb 9, 2024): You can try latest develop, yeah. Btw, what terminal application do you use?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 9, 2024):

I am seeing the error on a WSL2 Ubuntu through Wezterm and on an Arch install through ssh in Wezterm

@Pytness commented on GitHub (Feb 9, 2024): I am seeing the error on a WSL2 Ubuntu through Wezterm and on an Arch install through ssh in Wezterm

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 9, 2024):

I tried it now on Arch, using Wezterm, with zsh, p10k, instant prompt (selected verbose mode in the setup wizard), but can't reproduce it either.

@ku1ik commented on GitHub (Feb 9, 2024): I tried it now on Arch, using Wezterm, with zsh, p10k, instant prompt (selected verbose mode in the setup wizard), but can't reproduce it either.

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 9, 2024):

When you ssh to the Arch install, this is from Wezterm running on Windows maybe?

@ku1ik commented on GitHub (Feb 9, 2024): When you ssh to the Arch install, this is from Wezterm running on Windows maybe?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 9, 2024):

I installed p10k again (deleting instant prompt script) and Im getting same results.

When you ssh to the Arch install, this is from Wezterm running on Windows maybe?

Yes it is, but Im getting the same problem when connecting through other apps (I tried with an Android app, JuiceSSH)

@Pytness commented on GitHub (Feb 9, 2024): I installed p10k again (deleting instant prompt script) and Im getting same results. > When you ssh to the Arch install, this is from Wezterm running on Windows maybe? Yes it is, but Im getting the same problem when connecting through other apps (I tried with an Android app, JuiceSSH)

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@moritzdietz commented on GitHub (Feb 9, 2024):

Maybe this is something in your dotfiles / ZSH setup. Might be worthwhile to go as vanilla as possible and re-add your config things and see where it breaks?

Reason is: I know that when instant prompt launches and there is some kind of delay for it to launch caused by other things in the dotfiles, it will print out things. Maybe this is the case here?

@moritzdietz commented on GitHub (Feb 9, 2024): Maybe this is something in your dotfiles / ZSH setup. Might be worthwhile to go as vanilla as possible and re-add your config things and see where it breaks? Reason is: I know that when instant prompt launches and there is some kind of delay for it to launch caused by other things in the dotfiles, it will print out things. Maybe this is the case here?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 9, 2024):

Ok, so given it's the same on JuiceSSH, we can rule out Wezterm.

However I'm confused about instant prompt. You first wrote:

To be clear, I dont see the problem when I comment out the lines sourcing the instant prompt script.

And then:

I installed p10k again (deleting instant prompt script) and Im getting same results.

So it does or does not work without instant prompt?

@ku1ik commented on GitHub (Feb 9, 2024): Ok, so given it's the same on JuiceSSH, we can rule out Wezterm. However I'm confused about instant prompt. You first wrote: > To be clear, I dont see the problem when I comment out the lines sourcing the instant prompt script. And then: > I installed p10k again (deleting instant prompt script) and Im getting same results. So it does or does not work _without_ instant prompt?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 9, 2024):

It does work without instant prompt.

I removed the instant prompt script before reinstalling p10k (and configuring) to ensure the last version is installed. Sorry for the confusion.

I will try and bisect where else could it break.

@Pytness commented on GitHub (Feb 9, 2024): It does work without instant prompt. I removed the instant prompt script before reinstalling p10k (and configuring) to ensure the last version is installed. Sorry for the confusion. I will try and bisect where else could it break.

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 9, 2024):

From the demo you recorded it seems to me that the zsh process actually doesn't fully exit. asciinema finishes when the shell process exits and the allocated PTY for the shell gets closed. So, for some reasone the slave side of the PTY doesn't get closed. (this is probably not useful to you, writing this more as a note for myself :))

@ku1ik commented on GitHub (Feb 9, 2024): From the demo you recorded it seems to me that the zsh process actually doesn't fully exit. asciinema finishes when the shell process exits and the allocated PTY for the shell gets closed. So, for some reasone the slave side of the PTY doesn't get closed. (this is probably not useful to you, writing this more as a note for myself :))

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 9, 2024):

Doing kill -9 $$ outputs Killed but still the same issue.

@Pytness commented on GitHub (Feb 9, 2024): Doing `kill -9 $$` outputs Killed but still the same issue.

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 9, 2024):

Are you able to install asciinema 2.4.0 and test with it?

@ku1ik commented on GitHub (Feb 9, 2024): Are you able to install asciinema 2.4.0 and test with it?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 9, 2024):

Yes, same result. (I uninstalled the rust version)

@Pytness commented on GitHub (Feb 9, 2024): Yes, same result. (I uninstalled the rust version)

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 9, 2024):

I am playing with the source code and It gets stuck at pty::handle_child on execvp.
It seems to me that there is not much to be done?

@Pytness commented on GitHub (Feb 9, 2024): I am playing with the source code and It gets stuck at pty::handle_child on execvp. It seems to me that there is not much to be done?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@ku1ik commented on GitHub (Feb 9, 2024):

Right, so this confirms that zsh process doesn't exit, for some reason.

Can you try recording with the script command instead of asciinema? Or with ttyrec?

@ku1ik commented on GitHub (Feb 9, 2024): Right, so this confirms that zsh process doesn't exit, for some reason. Can you try recording with the `script` command instead of asciinema? Or with `ttyrec`?

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 12, 2024):

Using script zsh exits.

@Pytness commented on GitHub (Feb 12, 2024): Using `script` zsh exits.

kerem commented

2026-02-25 20:33:19 +03:00

Author

Owner

@Pytness commented on GitHub (Feb 12, 2024):

Comparing with the script command source code, I found out it calls some function ul_pty_signals_setup.
In that function it sets some signals:

sigaddset(&ourset, SIGCHLD);
sigaddset(&ourset, SIGWINCH);
sigaddset(&ourset, SIGALRM);
sigaddset(&ourset, SIGTERM);
sigaddset(&ourset, SIGINT);
sigaddset(&ourset, SIGQUIT);

I noticed that in asciinema, the sigalrm and sigchld are not being handled.

Handling this signals allows zsh to exit nicely.
I will open a PR.

@Pytness commented on GitHub (Feb 12, 2024): Comparing with the `script` command source code, I found out it calls some function `ul_pty_signals_setup`. In that function it sets some signals: ``` sigaddset(&ourset, SIGCHLD); sigaddset(&ourset, SIGWINCH); sigaddset(&ourset, SIGALRM); sigaddset(&ourset, SIGTERM); sigaddset(&ourset, SIGINT); sigaddset(&ourset, SIGQUIT); ``` I noticed that in `asciinema`, the `sigalrm` and `sigchld` are not being handled. Handling this signals allows zsh to exit nicely. I will open a PR.

kerem referenced this issue

2026-03-15 10:37:35 +03:00

[GH-ISSUE #317] when record has rz sz command the player will hangs #825

Rows
Columns

[GH-ISSUE #613] Recording wont exit when using P10k's instant prompt #317