[GH-ISSUE #387] Valid filenames can be misunderstood as http URL in url_open #243

Closed
opened 2026-02-25 20:33:09 +03:00 by kerem · 1 comment
Owner

Originally created by @s-leroux on GitHub (Feb 3, 2020).
Original GitHub issue: https://github.com/asciinema/asciinema/issues/387

http:example.cast is valid filename. But, given the code below from url_open, it seems it would be misunderstood as an HTTP URL:

github.com/asciinema/asciinema@350d5e9d8b/asciinema/asciicast/init.py#L45

Can someone confirm that?

Originally created by @s-leroux on GitHub (Feb 3, 2020). Original GitHub issue: https://github.com/asciinema/asciinema/issues/387 `http:example.cast` is valid filename. But, given the code below from `url_open`, it seems it would be misunderstood as an HTTP URL: https://github.com/asciinema/asciinema/blob/350d5e9d8b7cee1be5db4091815942c9d035e7dc/asciinema/asciicast/__init__.py#L45 Can someone confirm that?
kerem closed this issue 2026-02-25 20:33:09 +03:00
Author
Owner

@AemJane commented on GitHub (Jun 30, 2022):

Avcisrs-aus.ea/s$

<!-- gh-comment-id:1170639351 --> @AemJane commented on GitHub (Jun 30, 2022): Avcisrs-aus.ea/s$
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asciinema#243
No description provided.