[PR #690] [MERGED] Require at least one of -l / -r for session command #1188

New issue

Closed

opened 2026-03-15 11:23:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:23:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/690
Author: @moritzdietz
Created: 7/3/2025
Status: ✅ Merged
Merged: 7/10/2025
Merged by: @ku1ik

Base: develop ← Head: fix-session-args

📝 Commits (2)

116fd90 Require at least one of -l / -r for session command
f7a94fd Also require -o / --output-file for session command

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/cli.rs (+1 -0)

📄 Description

As of right now I didn't include the options -o / --output as one of the required sets of args.
I remember you saying that asciinema session is a mix of record and stream, but I understood it being more "stream" than recording so I didn't add it as one of the required args.

Hence the draft PR

This fixes #689

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/690 **Author:** [@moritzdietz](https://github.com/moritzdietz) **Created:** 7/3/2025 **Status:** ✅ Merged **Merged:** 7/10/2025 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `fix-session-args` --- ### 📝 Commits (2) - [`116fd90`](https://github.com/asciinema/asciinema/commit/116fd90bc21cdd38e5bad3c87c09fc1a0097119b) Require at least one of -l / -r for session command - [`f7a94fd`](https://github.com/asciinema/asciinema/commit/f7a94fd098c31d85b0394b45b9c6f30c626ca933) Also require -o / --output-file for session command ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cli.rs` (+1 -0) </details> ### 📄 Description As of right now I didn't include the options `-o / --output` as one of the required sets of args. I remember you saying that `asciinema session` is a mix of `record` and `stream`, but I understood it being more "stream" than recording so I didn't add it as one of the required args. Hence the draft PR This fixes #689 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>