[PR #653] [MERGED] Use safe kill from nix crate #1172

New issue

Closed

opened 2026-03-15 11:22:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:22:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/653
Author: @kxxt
Created: 10/5/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @ku1ik

Base: develop ← Head: kill-child-safely

📝 Commits (1)

716d6a0 Use safe kill from nix crate

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 src/pty.rs (+3 -2)

📄 Description

Previously the code uses unsafe kill from libc and on the first look it appears that it forgets to check the result.

I think you mean to ignore the errors that might occur when killing the child, right? This commit makes the intent more clear with less unsafe code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/653 **Author:** [@kxxt](https://github.com/kxxt) **Created:** 10/5/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `kill-child-safely` --- ### 📝 Commits (1) - [`716d6a0`](https://github.com/asciinema/asciinema/commit/716d6a0ae18d2c0dd6aea2e3b1d5d4a6c0683d2c) Use safe kill from nix crate ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/pty.rs` (+3 -2) </details> ### 📄 Description Previously the code uses unsafe kill from libc and on the first look it appears that it forgets to check the result. I think you mean to ignore the errors that might occur when killing the child, right? This commit makes the intent more clear with less unsafe code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>