[PR #616] [MERGED] Bugfix: handle SIGALRM and SIGCHLD signals. Fixes #613 #1152

Closed
opened 2026-03-15 11:21:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/616
Author: @Pytness
Created: 2/12/2024
Status: Merged
Merged: 2/14/2024
Merged by: @ku1ik

Base: developHead: add-missing-signals


📝 Commits (3)

  • 4ad6993 Add signal handling for SIGALRM and SIGCHLD in copy function
  • 38effe8 Change var order to follow previous standard
  • b2a1cb2 Import new signals from signal_hook::consts

📊 Changes

1 file changed (+16 additions, -2 deletions)

View changed files

📝 src/pty.rs (+16 -2)

📄 Description

Fixes https://github.com/asciinema/asciinema/issues/613.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/616 **Author:** [@Pytness](https://github.com/Pytness) **Created:** 2/12/2024 **Status:** ✅ Merged **Merged:** 2/14/2024 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `add-missing-signals` --- ### 📝 Commits (3) - [`4ad6993`](https://github.com/asciinema/asciinema/commit/4ad6993027778d3907991c5eaae6b8e7394dcbf6) Add signal handling for SIGALRM and SIGCHLD in copy function - [`38effe8`](https://github.com/asciinema/asciinema/commit/38effe8084dba723b09f34f3a008afa17ee1e0b9) Change var order to follow previous standard - [`b2a1cb2`](https://github.com/asciinema/asciinema/commit/b2a1cb28ab360629efd2b5b5c086278f431bf845) Import new signals from `signal_hook::consts` ### 📊 Changes **1 file changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/pty.rs` (+16 -2) </details> ### 📄 Description Fixes https://github.com/asciinema/asciinema/issues/613. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-15 11:21:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asciinema#1152
No description provided.