mirror of
https://github.com/asciinema/asciinema.git
synced 2026-04-26 00:15:56 +03:00
[PR #547] [CLOSED] Add --suppress-output flag to record command #1118
Labels
No labels
bug
compatibility
feature request
fit for beginners
help wanted
hosting
idea
improvement
packaging
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asciinema#1118
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/asciinema/asciinema/pull/547
Author: @DavidVentura
Created: 4/27/2023
Status: ❌ Closed
Base:
main← Head:suppress-output📝 Commits (1)
0123f13Add--suppress-outputflag torecordcommand📊 Changes
8 files changed (+88 additions, -1 deletions)
View changed files
📝
asciinema/__init__.py(+2 -0)📝
asciinema/__main__.py(+6 -0)📝
asciinema/commands/record.py(+2 -0)📝
asciinema/config.py(+4 -0)📝
asciinema/pty_.py(+3 -1)📝
asciinema/recorder.py(+2 -0)📝
tests/config_test.py(+11 -0)📝
tests/pty_test.py(+58 -0)📄 Description
Hi
This PR implements a new flag for the
recordcommand:--suppress-output.This allows certain use-cases, like running recorded integration tests in CI without the commands' output polluting logs.
I've only added unit-tests, as I could not get the expected integration test to work in
asciinemabefore my changes:I would've expected
wcto return28.Which I'd have compared with
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.