[PR #472] [MERGED] Recorder refactoring #1089

New issue

Closed

opened 2026-03-15 11:17:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:17:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/472
Author: @ku1ik
Created: 2/17/2022
Status: ✅ Merged
Merged: 2/19/2022
Merged by: @ku1ik

Base: develop ← Head: recorder-refa

📝 Commits (5)

760a715 Simplify async_writer
59f8a40 Handle time offset in async_writer instead of pty
e86dbc9 Handle conditional stdin recording in async_writer instead of pty
ed017ee Less defensive programming, rename test mock class
0a3e552 Use notifier's public notify method for file writer

📊 Changes

6 files changed (+41 additions, -68 deletions)

View changed files

📝 asciinema/__init__.py (+2 -2)
📝 asciinema/commands/record.py (+3 -3)
📝 asciinema/notifier.py (+1 -1)
📝 asciinema/pty_.py (+7 -17)
📝 asciinema/recorder.py (+21 -41)
📝 tests/pty_test.py (+7 -4)

📄 Description

Various code cleanups around the recorder module.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/472 **Author:** [@ku1ik](https://github.com/ku1ik) **Created:** 2/17/2022 **Status:** ✅ Merged **Merged:** 2/19/2022 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `recorder-refa` --- ### 📝 Commits (5) - [`760a715`](https://github.com/asciinema/asciinema/commit/760a7152e24962f255311b0ed57a4d33cc9b85ee) Simplify async_writer - [`59f8a40`](https://github.com/asciinema/asciinema/commit/59f8a40387588a658904c6d129be5c3392931ac9) Handle time offset in async_writer instead of pty - [`e86dbc9`](https://github.com/asciinema/asciinema/commit/e86dbc9118b2893e88cdcc3c86f658161037e0cb) Handle conditional stdin recording in async_writer instead of pty - [`ed017ee`](https://github.com/asciinema/asciinema/commit/ed017ee41fbd84b60ccb96f64a0db5e941b1c365) Less defensive programming, rename test mock class - [`0a3e552`](https://github.com/asciinema/asciinema/commit/0a3e5522ed8feae7b1a3a909c16840531034e8f9) Use notifier's public notify method for file writer ### 📊 Changes **6 files changed** (+41 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/__init__.py` (+2 -2) 📝 `asciinema/commands/record.py` (+3 -3) 📝 `asciinema/notifier.py` (+1 -1) 📝 `asciinema/pty_.py` (+7 -17) 📝 `asciinema/recorder.py` (+21 -41) 📝 `tests/pty_test.py` (+7 -4) </details> ### 📄 Description Various code cleanups around the recorder module. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>