[PR #458] [CLOSED] djds/build #1083

New issue

Closed

opened 2026-03-15 11:17:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:17:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/458
Author: @djds
Created: 12/11/2021
Status: ❌ Closed

Base: develop ← Head: djds/build

📝 Commits (10+)

8622387 [build] Refactor Makefile
d30de06 Convert setup.py to setup.cfg, pyproject.toml
a61744c [build] Add clean, clean.all targets to Makefile
95dfbae [build] Run build target in VIRTUAL_ENV
e5f0ee0 [build] Remove .mypy_cache with clean.all Makefile target
4d5aefa [container] Update Dockerfile for PEP 518 build
c034f70 [style] Add pre-commit config
fad2023 [style] Disable pylint invalid-name
bd264f0 [test] Configure pylint
33f0534 [ci] Format asciinema workflow; add Python 3.10

📊 Changes

13 files changed (+409 additions, -135 deletions)

View changed files

📝 .github/workflows/asciinema.yml (+84 -18)
➕ .pre-commit-config.yaml (+31 -0)
📝 Dockerfile (+8 -7)
📝 Makefile (+55 -15)
➕ pyproject.toml (+37 -0)
📝 setup.cfg (+58 -0)
➖ setup.py (+0 -58)
➕ tests/distros/Dockerfile.alpine (+19 -0)
➕ tests/distros/Dockerfile.arch (+22 -0)
📝 tests/distros/Dockerfile.centos (+16 -8)
📝 tests/distros/Dockerfile.debian (+31 -11)
📝 tests/distros/Dockerfile.fedora (+18 -7)
📝 tests/distros/Dockerfile.ubuntu (+30 -11)

📄 Description

[build] Refactor Makefile
Convert setup.py to setup.cfg, pyproject.toml
[build] Add clean, clean.all targets to Makefile
[build] Run build target in VIRTUAL_ENV
[build] Remove .mypy_cache with clean.all Makefile target
[container] Update Dockerfile for PEP 518 build
[style] Add pre-commit config
[style] Disable pylint invalid-name
[test] Configure pylint

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/458 **Author:** [@djds](https://github.com/djds) **Created:** 12/11/2021 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `djds/build` --- ### 📝 Commits (10+) - [`8622387`](https://github.com/asciinema/asciinema/commit/862238761146022f019a050e9e922ef6f53d0f94) [build] Refactor Makefile - [`d30de06`](https://github.com/asciinema/asciinema/commit/d30de06363ff5ee15df2bf884f7c649db75301d5) Convert setup.py to setup.cfg, pyproject.toml - [`a61744c`](https://github.com/asciinema/asciinema/commit/a61744c6a9ecc84c6f76ba7d09d9f1730ea89cd0) [build] Add clean, clean.all targets to Makefile - [`95dfbae`](https://github.com/asciinema/asciinema/commit/95dfbae68c212de41d17d117a4e277bbdffbb9fc) [build] Run build target in VIRTUAL_ENV - [`e5f0ee0`](https://github.com/asciinema/asciinema/commit/e5f0ee03a77c0965c4803216015bc0da3413fea4) [build] Remove .mypy_cache with clean.all Makefile target - [`4d5aefa`](https://github.com/asciinema/asciinema/commit/4d5aefa5908d269addeee037ff92e528861b652e) [container] Update Dockerfile for PEP 518 build - [`c034f70`](https://github.com/asciinema/asciinema/commit/c034f70992b5221880a955bd3285c490dce52b8a) [style] Add pre-commit config - [`fad2023`](https://github.com/asciinema/asciinema/commit/fad2023132559a1e480f4d5f0419cabba69e2201) [style] Disable pylint invalid-name - [`bd264f0`](https://github.com/asciinema/asciinema/commit/bd264f0ce5a1dfa5c9461c4afca6f69dca229a85) [test] Configure pylint - [`33f0534`](https://github.com/asciinema/asciinema/commit/33f053464ce6b5b378cfa7d84c19b04a51c8e036) [ci] Format asciinema workflow; add Python 3.10 ### 📊 Changes **13 files changed** (+409 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/asciinema.yml` (+84 -18) ➕ `.pre-commit-config.yaml` (+31 -0) 📝 `Dockerfile` (+8 -7) 📝 `Makefile` (+55 -15) ➕ `pyproject.toml` (+37 -0) 📝 `setup.cfg` (+58 -0) ➖ `setup.py` (+0 -58) ➕ `tests/distros/Dockerfile.alpine` (+19 -0) ➕ `tests/distros/Dockerfile.arch` (+22 -0) 📝 `tests/distros/Dockerfile.centos` (+16 -8) 📝 `tests/distros/Dockerfile.debian` (+31 -11) 📝 `tests/distros/Dockerfile.fedora` (+18 -7) 📝 `tests/distros/Dockerfile.ubuntu` (+30 -11) </details> ### 📄 Description - [build] Refactor Makefile - Convert setup.py to setup.cfg, pyproject.toml - [build] Add clean, clean.all targets to Makefile - [build] Run build target in VIRTUAL_ENV - [build] Remove .mypy_cache with clean.all Makefile target - [container] Update Dockerfile for PEP 518 build - [style] Add pre-commit config - [style] Disable pylint invalid-name - [test] Configure pylint --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>