[PR #455] [CLOSED] Replace nose with unittest #1078

New issue

Closed

opened 2026-03-15 11:17:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:17:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/455
Author: @stratakis
Created: 12/8/2021
Status: ❌ Closed

Base: develop ← Head: nose_replacement

📝 Commits (2)

e47412b Replace nose with unittest
8f8d524 Remove unused code

📊 Changes

19 files changed (+236 additions, -284 deletions)

View changed files

📝 .github/workflows/asciinema.yml (+0 -2)
📝 .gitignore (+0 -1)
📝 Makefile (+2 -2)
📝 asciinema/tests/__init__.py (+0 -0)
📝 asciinema/tests/asciicast/__init__.py (+0 -0)
📝 asciinema/tests/asciicast/test_v2.py (+6 -2)
📝 asciinema/tests/demo.cast (+0 -0)
📝 asciinema/tests/demo.json (+0 -0)
📝 asciinema/tests/distros.sh (+2 -2)
📝 asciinema/tests/distros/Dockerfile.centos (+0 -1)
📝 asciinema/tests/distros/Dockerfile.debian (+0 -1)
📝 asciinema/tests/distros/Dockerfile.fedora (+0 -1)
📝 asciinema/tests/distros/Dockerfile.ubuntu (+0 -1)
📝 asciinema/tests/integration.sh (+10 -10)
➕ asciinema/tests/test_config.py (+191 -0)
➕ asciinema/tests/test_helper.py (+20 -0)
📝 asciinema/tests/test_pty.py (+5 -2)
➖ tests/config_test.py (+0 -208)
➖ tests/test_helper.py (+0 -51)

📄 Description

This PR is quite extensive as it re-organizes the tests directory structure in order to make it compatible with unittest, however I hope the conversion is pretty straightforward. This way the tests can be run via the command line python3 -m unittest discover or also by invoking pytest directly should anyone desires. I've removed some unused code as well.

All the tests pass locally with this PR, I haven't checked the integration tests though.

Resolves #388

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/455 **Author:** [@stratakis](https://github.com/stratakis) **Created:** 12/8/2021 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `nose_replacement` --- ### 📝 Commits (2) - [`e47412b`](https://github.com/asciinema/asciinema/commit/e47412b610d353ce06dc9d0aab608db12eeba172) Replace nose with unittest - [`8f8d524`](https://github.com/asciinema/asciinema/commit/8f8d524957381d8156d0693226d6c68bcc997e9f) Remove unused code ### 📊 Changes **19 files changed** (+236 additions, -284 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/asciinema.yml` (+0 -2) 📝 `.gitignore` (+0 -1) 📝 `Makefile` (+2 -2) 📝 `asciinema/tests/__init__.py` (+0 -0) 📝 `asciinema/tests/asciicast/__init__.py` (+0 -0) 📝 `asciinema/tests/asciicast/test_v2.py` (+6 -2) 📝 `asciinema/tests/demo.cast` (+0 -0) 📝 `asciinema/tests/demo.json` (+0 -0) 📝 `asciinema/tests/distros.sh` (+2 -2) 📝 `asciinema/tests/distros/Dockerfile.centos` (+0 -1) 📝 `asciinema/tests/distros/Dockerfile.debian` (+0 -1) 📝 `asciinema/tests/distros/Dockerfile.fedora` (+0 -1) 📝 `asciinema/tests/distros/Dockerfile.ubuntu` (+0 -1) 📝 `asciinema/tests/integration.sh` (+10 -10) ➕ `asciinema/tests/test_config.py` (+191 -0) ➕ `asciinema/tests/test_helper.py` (+20 -0) 📝 `asciinema/tests/test_pty.py` (+5 -2) ➖ `tests/config_test.py` (+0 -208) ➖ `tests/test_helper.py` (+0 -51) </details> ### 📄 Description This PR is quite extensive as it re-organizes the tests directory structure in order to make it compatible with unittest, however I hope the conversion is pretty straightforward. This way the tests can be run via the command line `python3 -m unittest discover` or also by invoking `pytest` directly should anyone desires. I've removed some unused code as well. All the tests pass locally with this PR, I haven't checked the integration tests though. Resolves #388 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>