[PR #445] [MERGED] Add PEP 518 build; annotate types; drop Python < 3.6 support #1075

New issue

Closed

opened 2026-03-15 11:17:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:17:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/445
Author: @djds
Created: 11/5/2021
Status: ✅ Merged
Merged: 2/13/2022
Merged by: @ku1ik

Base: develop ← Head: develop

📝 Commits (10+)

7bbc89b [ci] Format asciinema workflow; add Python 3.10
a89cc2d [test] Shellcheck tests/*.sh
2bfb38c [build] Refactor Makefile
fe5433e Convert setup.py to setup.cfg, pyproject.toml
07b29ee [test] Fix imports in tests/config_test.py
533b074 [doc] Update README
9eab5f5 [container] Update Dockerfile for PEP 518 build
dcf4f3f [test] Update test distro Dockerfiles
bd3e6f5 [test] Convert unittests runner nose => pytest
66534d2 [ci] Run container integration tests to CI

📊 Changes

44 files changed (+1821 additions, -1006 deletions)

View changed files

➕ .github/dependabot.yml (+7 -0)
📝 .github/workflows/asciinema.yml (+84 -18)
➕ .pre-commit-config.yaml (+40 -0)
📝 Dockerfile (+8 -7)
📝 Makefile (+60 -16)
📝 README.md (+112 -57)
📝 asciinema/__init__.py (+22 -11)
📝 asciinema/__main__.py (+143 -55)
📝 asciinema/api.py (+53 -36)
📝 asciinema/asciicast/__init__.py (+85 -59)
📝 asciinema/asciicast/events.py (+25 -12)
📝 asciinema/asciicast/raw.py (+28 -13)
📝 asciinema/asciicast/v1.py (+30 -28)
📝 asciinema/asciicast/v2.py (+84 -59)
📝 asciinema/async_worker.py (+22 -12)
📝 asciinema/commands/auth.py (+15 -11)
📝 asciinema/commands/cat.py (+14 -13)
📝 asciinema/commands/command.py (+21 -12)
📝 asciinema/commands/play.py (+20 -10)
📝 asciinema/commands/record.py (+66 -41)

...and 24 more files

📄 Description

[ci] Format asciinema workflow; add Python 3.10
[test] Shellcheck tests/*.sh
[build] Refactor Makefile
Convert setup.py to setup.cfg, pyproject.toml
[test] Fix imports in tests/config_test.py
[doc] Update README
[container] Update Dockerfile for PEP 518 build
[test] Update test distro Dockerfiles
[test] Convert unittests runner nose => pytest
[ci] Run container integration tests to CI
[ci] Add dependabot config
[style] Add pre-commit config
[style] Format package code
[style] Ignore line break before binary operator
[style] Replace calls to format() with f-strings
[style] Disable pylint invalid-name
Rename asciinema/pty.py => pty_.py
[typing] Annotate asciinema.asciicast
[typing] Annotate asciinema.async_worker
[test] Update test for asciinema.pty_
[test] Drop support for Python 3.6; upgrade CentOS
[build] Add clean, clean.all targets to Makefile
[typing] Annotate ascinnema.urllib_http_adapter
[typing] Annotate asciinema.api
[typing] Annotate asciinema.config
[typing] Annotate asciinema.term
[typing] Annotate asciinema.pty_
[typing] Annotate asciinema.main
[typing] Annotate asciinema.player
[typing] Annotate asciinema.recorder
[test] Configure pylint
[test] Format v2 test
[test] Format test_helper
Refactor asciinema.notifier
[typing] Annotate asciinema.commands.auth
[build] Run build target in VIRTUAL_ENV
[typing] Annotate asciinema.commands.upload
[typing] Annotate asciinema.commands.record
[typing] Annotate asciinema.init
[typing] Annotate asciinema.commands.cat
[typing] Annotate asciinema.commands.command
[typing] Annotate asciinema.commands.play
[typing] Add asciinema/py.typed
Revert "[test] Drop support for Python 3.6; upgrade CentOS"
Support Python 3.6; remove annotations from future
v2.2.0: Require Python 3.6+

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/445 **Author:** [@djds](https://github.com/djds) **Created:** 11/5/2021 **Status:** ✅ Merged **Merged:** 2/13/2022 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`7bbc89b`](https://github.com/asciinema/asciinema/commit/7bbc89b65ca7a24409d83fd25eb5f9a10a2ccff3) [ci] Format asciinema workflow; add Python 3.10 - [`a89cc2d`](https://github.com/asciinema/asciinema/commit/a89cc2d6f963b4284371dffa355bcbff1c4bd5b5) [test] Shellcheck tests/*.sh - [`2bfb38c`](https://github.com/asciinema/asciinema/commit/2bfb38c1f3efe8493a3d6608b55a6fa41c513085) [build] Refactor Makefile - [`fe5433e`](https://github.com/asciinema/asciinema/commit/fe5433e61e24260fe4f95d1c0589d5c60b74575d) Convert setup.py to setup.cfg, pyproject.toml - [`07b29ee`](https://github.com/asciinema/asciinema/commit/07b29ee2b51e227c59ebd6ed4a0ce387625a5fee) [test] Fix imports in tests/config_test.py - [`533b074`](https://github.com/asciinema/asciinema/commit/533b074759380d3042a6155abc06e9dd9410a4b2) [doc] Update README - [`9eab5f5`](https://github.com/asciinema/asciinema/commit/9eab5f5cb7220e65ee39f2cea36e3665ddc61b13) [container] Update Dockerfile for PEP 518 build - [`dcf4f3f`](https://github.com/asciinema/asciinema/commit/dcf4f3f9ca21938f4c185ae8d348ce1d8e27d6cd) [test] Update test distro Dockerfiles - [`bd3e6f5`](https://github.com/asciinema/asciinema/commit/bd3e6f5f676a61fe0f0a8e31ae7e9152761f797b) [test] Convert unittests runner nose => pytest - [`66534d2`](https://github.com/asciinema/asciinema/commit/66534d258dc90020a3e77c405bce459524154817) [ci] Run container integration tests to CI ### 📊 Changes **44 files changed** (+1821 additions, -1006 deletions) <details> <summary>View changed files</summary> ➕ `.github/dependabot.yml` (+7 -0) 📝 `.github/workflows/asciinema.yml` (+84 -18) ➕ `.pre-commit-config.yaml` (+40 -0) 📝 `Dockerfile` (+8 -7) 📝 `Makefile` (+60 -16) 📝 `README.md` (+112 -57) 📝 `asciinema/__init__.py` (+22 -11) 📝 `asciinema/__main__.py` (+143 -55) 📝 `asciinema/api.py` (+53 -36) 📝 `asciinema/asciicast/__init__.py` (+85 -59) 📝 `asciinema/asciicast/events.py` (+25 -12) 📝 `asciinema/asciicast/raw.py` (+28 -13) 📝 `asciinema/asciicast/v1.py` (+30 -28) 📝 `asciinema/asciicast/v2.py` (+84 -59) 📝 `asciinema/async_worker.py` (+22 -12) 📝 `asciinema/commands/auth.py` (+15 -11) 📝 `asciinema/commands/cat.py` (+14 -13) 📝 `asciinema/commands/command.py` (+21 -12) 📝 `asciinema/commands/play.py` (+20 -10) 📝 `asciinema/commands/record.py` (+66 -41) _...and 24 more files_ </details> ### 📄 Description - [ci] Format asciinema workflow; add Python 3.10 - [test] Shellcheck tests/*.sh - [build] Refactor Makefile - Convert setup.py to setup.cfg, pyproject.toml - [test] Fix imports in tests/config_test.py - [doc] Update README - [container] Update Dockerfile for PEP 518 build - [test] Update test distro Dockerfiles - [test] Convert unittests runner nose => pytest - [ci] Run container integration tests to CI - [ci] Add dependabot config - [style] Add pre-commit config - [style] Format package code - [style] Ignore line break before binary operator - [style] Replace calls to format() with f-strings - [style] Disable pylint invalid-name - Rename asciinema/pty.py => pty_.py - [typing] Annotate asciinema.asciicast - [typing] Annotate asciinema.async_worker - [test] Update test for asciinema.pty_ - [test] Drop support for Python 3.6; upgrade CentOS - [build] Add clean, clean.all targets to Makefile - [typing] Annotate ascinnema.urllib_http_adapter - [typing] Annotate asciinema.api - [typing] Annotate asciinema.config - [typing] Annotate asciinema.term - [typing] Annotate asciinema.pty_ - [typing] Annotate asciinema.__main__ - [typing] Annotate asciinema.player - [typing] Annotate asciinema.recorder - [test] Configure pylint - [test] Format v2 test - [test] Format test_helper - Refactor asciinema.notifier - [typing] Annotate asciinema.commands.auth - [build] Run build target in VIRTUAL_ENV - [typing] Annotate asciinema.commands.upload - [typing] Annotate asciinema.commands.record - [typing] Annotate asciinema.__init__ - [typing] Annotate asciinema.commands.cat - [typing] Annotate asciinema.commands.command - [typing] Annotate asciinema.commands.play - [typing] Add asciinema/py.typed - Revert "[test] Drop support for Python 3.6; upgrade CentOS" - Support Python 3.6; remove annotations from __future__ - v2.2.0: Require Python 3.6+ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>