mirror of
https://github.com/asciinema/asciinema.git
synced 2026-04-24 23:45:50 +03:00
[GH-ISSUE #140] Will not survive window resizing #107
Labels
No labels
bug
compatibility
feature request
fit for beginners
help wanted
hosting
idea
improvement
packaging
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/asciinema#107
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @karelbilek on GitHub (Jan 27, 2016).
Original GitHub issue: https://github.com/asciinema/asciinema/issues/140
When you start asciinema in a large terminal window, then resize the window (during recording) to smaller size, the video comes out all wrong.
Interestingly enough, it survives well in the opposite way.
In this example, I run
sl- my favourite program - in a big terminal window, then resize the window to small window (that's the "awkward pause" - me resizing the window) and runslagain. The second run looks OK, but the first is mangled.https://asciinema.org/a/5wvarzb4545pohhfqnj8g9fta
For illustration, this is opposite example. Starting small, then resizing to big. Both runs work well.
http://asciinema.org/a/d9u278gcavlymvywrleh0kbup
@ku1ik commented on GitHub (Jan 27, 2016):
asciinema doesn't record screen but the stdout stream. It also saves the current terminal dimensions at the end of the recording session. Some terminal apps (as
sl) are depending on the actual terminal size. They produce escape sequences that are suited for the current terminal width/height at any given point in time. Because asciinema player actually interprets/executes recorded stdout, these escape sequences are executed against the current asciinema terminal size.In other words, to solve this problem asciinema would need to save the terminal resize events (this can be done) and then use them to resize its own "terminal" during the playback. However, that would cause the resizing of the player itself, which would look funny (when replayed on asciinema.org) and be impractical (when embedded on a site).
@karelbilek commented on GitHub (Jan 27, 2016):
I understand the challenges and I understand if you don't want to fix it, I just wanted to let you know.
It could be solved by making the player the maximal width of all the widths and the maximal height of all the heights and the text could be in top left - it would be the same case as if you start with small terminal and end with big terminal. I don't know if it's worth fixing though :)
@ku1ik commented on GitHub (Jan 27, 2016):
It's not that I don't want to fix it, but there are more subtleties with this (your proposed solution would still give bad results in some cases). Anyway, this is kind of an edge case, and I'm too not sure if it's worth fixing.
I'm leaving this open though.
@xloem commented on GitHub (Nov 6, 2016):
This is issue would prohibit casual use of asciinema to record all daily work, creating an irritating limitation to never shrink terminal windows.
@mukkachaitanya commented on GitHub (Mar 2, 2017):
I think there must be a flexibility for dimens. I had recorded a video (here) and it came out in awkward dimens, i.e. the embedded video took more that the height of the page. Now, I have no choice other than recording again.
I even tried to change the width and height in the
.json, which of course didn't work well, as I was having overlapping (this)P.S Even though this is off topic of the above discussion, this was the closest issue I could find regarding this.
@ku1ik commented on GitHub (Mar 15, 2017):
@xloem @mukkachaitanya I am designing new recording format (https://github.com/asciinema/asciinema/pull/196). Maybe we could make it support "terminal resize" event...
@safinaskar commented on GitHub (May 9, 2017):
I need some util to "backup" my terminal activity. And, of course, this util should "just work" even if I resize terminal. Maybe there are other programs out there, which support the feature?
@jiangts commented on GitHub (Dec 21, 2017):
could you shed some light on how to capture the terminal resize event? Would be really useful in a branch I'm working on for realtime asciicasts (and the resize case during recording I'm sure)
@ku1ik commented on GitHub (Feb 4, 2018):
@jiangts here's the place where the recorder handles terminal resize (SIGWINCH signal): https://github.com/asciinema/asciinema/blob/develop/asciinema/pty_recorder.py#L108
@ku1ik commented on GitHub (Aug 14, 2023):
The fix is coming https://github.com/asciinema/asciinema-player/pull/244