[PR #400] [MERGED] Bugfix: Ensure ASCIINEMA_REC set on record (#372). #1057

New issue

Closed

opened 2026-03-15 11:16:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:16:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/400
Author: @landonb
Created: 3/25/2020
Status: ✅ Merged
Merged: 4/19/2020
Merged by: @ku1ik

Base: develop ← Head: issue/372/ASCIINEMA_REC-is-not-set

📝 Commits (1)

5051eb7 Bugfix: Ensure ASCIINEMA_REC set on record (#372).

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 asciinema/recorder.py (+1 -1)

📄 Description

A simple fix to the ASCIINEMA_REC issue: ASCIINEMA_REC is not set (#372).

To reproduce:

$ asciinema rec -c 'echo "ASCIINEMA_REC=$ASCIINEMA_REC"'
ASCIINEMA_REC=

Expected behavior:

$ asciinema rec -c 'echo "ASCIINEMA_REC=$ASCIINEMA_REC"'
ASCIINEMA_REC=1

Thanks for all your hard work!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/400 **Author:** [@landonb](https://github.com/landonb) **Created:** 3/25/2020 **Status:** ✅ Merged **Merged:** 4/19/2020 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `issue/372/ASCIINEMA_REC-is-not-set` --- ### 📝 Commits (1) - [`5051eb7`](https://github.com/asciinema/asciinema/commit/5051eb78680e08a2f4edf29450cfceaa9b8081e2) Bugfix: Ensure ASCIINEMA_REC set on record (#372). ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/recorder.py` (+1 -1) </details> ### 📄 Description A simple fix to the ASCIINEMA_REC issue: [ASCIINEMA_REC is not set (#372)](https://github.com/asciinema/asciinema/issues/372). To reproduce: $ asciinema rec -c 'echo "ASCIINEMA_REC=$ASCIINEMA_REC"' ASCIINEMA_REC= Expected behavior: $ asciinema rec -c 'echo "ASCIINEMA_REC=$ASCIINEMA_REC"' ASCIINEMA_REC=1 Thanks for all your hard work! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>