[PR #330] [MERGED] Change "how to stop recording" info message #1046

Closed
opened 2026-03-15 11:15:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/330
Author: @vanyakosmos
Created: 12/6/2018
Status: Merged
Merged: 12/8/2018
Merged by: @ku1ik

Base: developHead: fix-exit-msg


📝 Commits (2)

  • 5fd54dd add better gitignore file
  • a05bb5b change "how to stop recording" info message

📊 Changes

2 files changed (+126 additions, -6 deletions)

View changed files

📝 .gitignore (+117 -0)
📝 asciinema/commands/record.py (+9 -6)

📄 Description

  • prints "exit opened program when you're done" if command was specified, or "press or type "exit" when you're done" otherwise
  • add better .gitignore file from github/gitignore (+ old one). Added it because I needed to hide my .venv :(
  • slight refactoring (sort import, wrap really long line)

this pull request will close issue #328


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/330 **Author:** [@vanyakosmos](https://github.com/vanyakosmos) **Created:** 12/6/2018 **Status:** ✅ Merged **Merged:** 12/8/2018 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `fix-exit-msg` --- ### 📝 Commits (2) - [`5fd54dd`](https://github.com/asciinema/asciinema/commit/5fd54ddd218a36e9249153e91f46da9c6494a2ef) add better gitignore file - [`a05bb5b`](https://github.com/asciinema/asciinema/commit/a05bb5b0c16de4eaf2b96cdca07884b2dd373fc3) change "how to stop recording" info message ### 📊 Changes **2 files changed** (+126 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+117 -0) 📝 `asciinema/commands/record.py` (+9 -6) </details> ### 📄 Description - prints "exit opened program when you're done" if command was specified, or "press <ctrl-d> or type "exit" when you're done" otherwise - add better .gitignore file from [github/gitignore](https://github.com/github/gitignore/blob/master/Python.gitignore) (+ old one). Added it because I needed to hide my .venv :( - slight refactoring (sort import, wrap really long line) this pull request will close issue #328 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-15 11:15:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/asciinema#1046
No description provided.