[PR #234] [MERGED] Don't save user command, to avoid leaking secrets #1035

New issue

Closed

opened 2026-03-15 11:14:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:14:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/234
Author: @ku1ik
Created: 9/17/2017
Status: ✅ Merged
Merged: 10/27/2017
Merged by: @ku1ik

Base: develop ← Head: v2-dont-store-command

📝 Commits (1)

2217ee5 Don't save user command, to avoid leaking secrets

📊 Changes

1 file changed (+0 additions, -3 deletions)

View changed files

📝 asciinema/asciicast/v2.py (+0 -3)

📄 Description

This solves #216.

Example of secret leak:

asciinema rec -c 'export API_KEY=secret-stuff; ./script.sh'

The resulting asciicast would include "command": "export API_KEY=secret-stuff; ./script.sh".

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/234 **Author:** [@ku1ik](https://github.com/ku1ik) **Created:** 9/17/2017 **Status:** ✅ Merged **Merged:** 10/27/2017 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `develop` ← **Head:** `v2-dont-store-command` --- ### 📝 Commits (1) - [`2217ee5`](https://github.com/asciinema/asciinema/commit/2217ee5369c2794473d821c460ea93a74e058ccd) Don't save user command, to avoid leaking secrets ### 📊 Changes **1 file changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/asciicast/v2.py` (+0 -3) </details> ### 📄 Description This solves #216. Example of secret leak: asciinema rec -c 'export API_KEY=secret-stuff; ./script.sh' The resulting asciicast would include `"command": "export API_KEY=secret-stuff; ./script.sh"`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>