[PR #199] [CLOSED] Ignore stdin during playback #1024

New issue

Closed

opened 2026-03-15 11:14:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:14:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/199
Author: @cassdeckard
Created: 3/24/2017
Status: ❌ Closed

Base: master ← Head: ignore_stdin

📝 Commits (3)

fe0923c Take control of terminal on play and restore on exit
d00ce35 May as well use curses for everything
1eaeafe Fix PEP8 problems

📊 Changes

1 file changed (+26 additions, -8 deletions)

View changed files

📝 asciinema/player.py (+26 -8)

📄 Description

Potential fix for #108 using curses.

Also has the side-effect of clearing the terminal at the beginning of the playback and restoring it afterward, which seems like a good thing.

It would be pretty easy to implement #198 on top of this as well, since retrieving and setting the terminal size are simple functions in curses

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/199 **Author:** [@cassdeckard](https://github.com/cassdeckard) **Created:** 3/24/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ignore_stdin` --- ### 📝 Commits (3) - [`fe0923c`](https://github.com/asciinema/asciinema/commit/fe0923ca69486112e28bbd4266b81dc6b85edcc9) Take control of terminal on play and restore on exit - [`d00ce35`](https://github.com/asciinema/asciinema/commit/d00ce35150fa71776bbf758d2a5189f2a932c1b5) May as well use curses for everything - [`1eaeafe`](https://github.com/asciinema/asciinema/commit/1eaeafef94df7fbb1176403537f1d4641b341751) Fix PEP8 problems ### 📊 Changes **1 file changed** (+26 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/player.py` (+26 -8) </details> ### 📄 Description Potential fix for #108 using `curses`. Also has the side-effect of clearing the terminal at the beginning of the playback and restoring it afterward, which seems like a good thing. It would be pretty easy to implement #198 on top of this as well, since retrieving and setting the terminal size are simple functions in `curses` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>