[PR #193] [MERGED] Trap more signals than just SIGCHLD #1019

New issue

Closed

opened 2026-03-15 11:14:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:14:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/asciinema/asciinema/pull/193
Author: @typerlc
Created: 2/22/2017
Status: ✅ Merged
Merged: 3/9/2017
Merged by: @ku1ik

Base: master ← Head: catch-more

📝 Commits (1)

a4092f5 Trap more signals than just SIGCHLD

📊 Changes

1 file changed (+15 additions, -5 deletions)

View changed files

📝 asciinema/pty_recorder.py (+15 -5)

📄 Description

Properly write a recording file if asciinema is terminated with SIGHUP, SIGTERM, SIGQUIT. This happens, for example, if the machine is rebooted during a recording session.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/asciinema/asciinema/pull/193 **Author:** [@typerlc](https://github.com/typerlc) **Created:** 2/22/2017 **Status:** ✅ Merged **Merged:** 3/9/2017 **Merged by:** [@ku1ik](https://github.com/ku1ik) **Base:** `master` ← **Head:** `catch-more` --- ### 📝 Commits (1) - [`a4092f5`](https://github.com/asciinema/asciinema/commit/a4092f5493f03f5e9f507af74c92e93dfe024bf3) Trap more signals than just SIGCHLD ### 📊 Changes **1 file changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `asciinema/pty_recorder.py` (+15 -5) </details> ### 📄 Description Properly write a recording file if asciinema is terminated with SIGHUP, SIGTERM, SIGQUIT. This happens, for example, if the machine is rebooted during a recording session. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>