mirror of
https://github.com/anonaddy/anonaddy.git
synced 2026-04-25 06:05:55 +03:00
[GH-ISSUE #332] AnonAddy API returns aliases in chunks of 100 but the clients don't handle this paging properly and loose the data #839
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/anonaddy#839
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @w3lld0ne on GitHub (Sep 5, 2022).
Original GitHub issue: https://github.com/anonaddy/anonaddy/issues/332
Load app.anonaddy.com (you should have more than 100 aliases in total)
Here I have 108 active aliases by default:
Now I want to see my deleted aliases:
The new aliases count is now 100 in total (98 active + 2 inactive/deleted) which is false:
I've tried to hide deleted aliases again (not by reloading the page but by resetting the filter), but the total amount of alises is still capped by 100:
The oldest aliases are not displayed anymore (until I reload the page).
@w3lld0ne commented on GitHub (Sep 5, 2022):
This actually seems like the problem with API because mobile apps are also affected (they never load the full list of aliases, only the latest 100). Browser extension seems to not be affected but it loads aliases by chunks, few after few, maybe it does matter.
@w3lld0ne commented on GitHub (Sep 5, 2022):
I've also found out that when you initially load app.anonaddy.com page, it doesn't produce any API calls (thus initial load is unaffected by the problem), but whenever you touch the filter, an API call is made with the described bug.
This generally seems like you've tried to implement paging on the API side but the clients don't properly handle it and loose next pages of data.
@willbrowningme commented on GitHub (Sep 6, 2022):
Thanks, I am aware of the issue on the web application and will be fixing it soon in the new UI. This will fix the alias counts etc. too.
There is no issue with the API, it is paginated to 100 aliases per page by default - https://app.anonaddy.com/docs/#aliases-GETapi-v1-aliases
Some users have 10s of thousands of aliases so it is not feasible to allow an API call to fetch all of these in a single request.
That is why pagination was added, this is present in the browser extension where 10 aliases are fetched per page.
As KhalidWar mentioned the API allows you to search aliases by description or email server side.
@D3strukt0r commented on GitHub (May 2, 2023):
Still a problem. Makes sense you can't get all in one request. But it still makes sense to know what the total actually is, and that pagination would work like that. I have 485 aliases (recently renewed most of them, so equal number of deleted ones), switching to deleted ones, caps to 100 with 4 pages, which is clearly wrong
@willbrowningme commented on GitHub (Aug 24, 2023):
Should be sorted now.
@D3strukt0r commented on GitHub (Aug 24, 2023):
I do already miss being able to select the page size, having the option to see everything on one page and use the browser search was neat. Maybe create a new issue/request for that 🤔