mirror of
https://github.com/anonaddy/anonaddy.git
synced 2026-04-25 06:05:55 +03:00
[GH-ISSUE #605] Undelivered Mail Returned to Sender #437
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/anonaddy#437
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @luckydonald on GitHub (Feb 28, 2024).
Original GitHub issue: https://github.com/anonaddy/anonaddy/issues/605
Now additionally to that rather unhelpful error message (please just put the error there) the sender of that mail got this message back:
Undelivered Mail Returned to Sender
From: MAILER-DAEMON@anon.example.com
Attachments (2):
message-delivery-status-attachment
…Original Message Name.emlBody:
@luckydonald commented on GitHub (Feb 28, 2024):
Three issues here:
@willbrowningme commented on GitHub (Mar 1, 2024):
That failed delivery entry was created here - https://github.com/anonaddy/anonaddy/blob/master/app/Mail/ForwardEmail.php#L366-L376
I've just tested this replicating the same error and the sender of the email does not receive a bounce message.
When the ForwardEmail job is being run it means the message was already accepted into the mail server. So to the sender it will appear as if the message was delivered successfully.
I've just fixed that bug and also added the actual exception error message instead of the generic "please check the logs" message.
@luckydonald commented on GitHub (Mar 1, 2024):
Permanent link to the stuff from above:
github.com/anonaddy/anonaddy@7becf1ac87/app/Mail/ForwardEmail.php (L366-L376)I'm not sure if I understand correctly, you say there's no way the sender got that email?
Because that's just what I got back to my external mail I created to test the forwards.
@willbrowningme commented on GitHub (Mar 1, 2024):
What is the
QUEUE_CONNECTIONset as in your.envfile? Are you running with Docker or from the self-hosting instructions?@luckydonald commented on GitHub (Mar 1, 2024):
Good question.
am using the docker image and I don't think I did set it myself.
Likely can't check before Monday, but possibly empty?
As it's not documented in the readme there, I did not set it intentionally.
@willbrowningme commented on GitHub (Mar 1, 2024):
Run
docker compose exec addy anonaddy tinkerand then enterconfig('queue.default');.I suspect it will be
syncwhich would explain it not being queued.@luckydonald commented on GitHub (Mar 5, 2024):
Yes, I could confirm it's set to
sync.@willbrowningme commented on GitHub (Mar 6, 2024):
I've also just updated the catch statement to catch
\Throwableinstead of just\Exceptionin order to prevent any stack trace being leaked to the sender.@luckydonald commented on GitHub (Mar 25, 2024):
Will this make a release any time soon?
Currently I've rolled back to v0.14.0 as that one isn't blocking as many emails.
Notably it's blocking google account mails.
@willbrowningme commented on GitHub (Mar 25, 2024):
Just pushed a new release now.
@luckydonald commented on GitHub (Mar 25, 2024):
Thanks!
Could you also please bump the version in the docker repo?
Basically this line:
github.com/anonaddy/docker@3de44c7adf/Dockerfile (L3)