mirror of
https://github.com/anonaddy/anonaddy.git
synced 2026-04-25 14:15:53 +03:00
[GH-ISSUE #253] Remove Email Banner in replies #222
Labels
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/anonaddy#222
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @HeikoBornholdt on GitHub (Jan 11, 2022).
Original GitHub issue: https://github.com/anonaddy/anonaddy/issues/253
It would be great if the Email Banner could be automatically removed in replies.
This would prevent the AnonAddy URL and (private) description from being disclosed to the recipient.
@DNCD commented on GitHub (Feb 14, 2022):
you can remove the Email Banner for every email you receive by going into the settings, look for "Update Email Banner Location, and selecting OFF."
@J4NS-R commented on GitHub (Apr 15, 2022):
@heikobornholdt the feature has already been implemented. Please close this issue.
@HeikoBornholdt commented on GitHub (Apr 15, 2022):
Hey @Koellewe 👋,
Do you mean the feature mentioned by @DNCD ?
That's not actually the feature I suggested, as it will disable the banner at all.
My feature suggestion prevents the email banner information from being disclosed to the recipient when replying to an email.
@willbrowningme commented on GitHub (Nov 3, 2022):
This should be working now, please give it a try and let me know if everything is as expected. (It will only remove the banner from newly forwarded messages starting from now).
@nielscil commented on GitHub (Nov 7, 2022):
The plain text works good, but when using html and outlook desktop client the comments are being removed when replying:
Incoming
Outgoing
@willbrowningme commented on GitHub (Nov 8, 2022):
@nielscil have you confirmed that this means the banner is not successfully removed if sending from the Outlook desktop client? I have no idea why they would choose to remove HTML comments.
@nielscil commented on GitHub (Nov 8, 2022):
Yeah, it doesn't remove the banner.
@willbrowningme commented on GitHub (Nov 8, 2022):
Okay, thanks for the update, that is obviously a problem, I'll have to change the regex matches to something else that cannot be removed.
@willbrowningme commented on GitHub (Nov 8, 2022):
I can confirm that this was also affecting the Outlook mobile app. I've just pushed a fix for it now, please could you try it with a newly forwarded message?
@nielscil commented on GitHub (Nov 10, 2022):
Sure, but I don't see the fix in the commits of the repo yet.
@willbrowningme commented on GitHub (Nov 10, 2022):
I just pushed the commit to GitHub now -
github.com/anonaddy/anonaddy@fa5a7a87d7@nielscil commented on GitHub (Nov 12, 2022):
On mobile outlook it works indeed. From desktop it still does not. Output message does not contain the id to match anymore:
@willbrowningme commented on GitHub (Nov 14, 2022):
Was that a newly forwarded email? The banner only recently started to include the
id="banner-info".@nielscil commented on GitHub (Nov 14, 2022):
Yeah, it was. I can confirm that when I recieved the message the id was there, but when replying to it, it was removed.
@willbrowningme commented on GitHub (Nov 14, 2022):
Hmm, it is proving very difficult to write a fool-proof regular expression given all the alterations that seem to be happening by different email clients.
@willbrowningme commented on GitHub (Nov 14, 2022):
Okay, I think I've found a solution, please could you try again now.
@nielscil commented on GitHub (Nov 15, 2022):
Sure, could you commit your fix?
@willbrowningme commented on GitHub (Nov 15, 2022):
Just pushed the commit live now -
github.com/anonaddy/anonaddy@24b8286675@nielscil commented on GitHub (Nov 16, 2022):
I've tested the latest fix and it seems to be working now on Outlook desktop and in the outlook android app. Tnx!
@alexaka1 commented on GitHub (Feb 11, 2023):
Does this still work?
Replying to an email from Protonmail (both web and android), keeps the banner in the "Show original" menu in Gmail.
When opening the email in gmail (web), the history has no visible trace of the banner. But clicking the "Show original" menu, and ctrl+f deactivate, it's still there in the body. (Actually on further inspection, it's not removed from the plaintext part only.)
Mobile:
Web:
@willbrowningme commented on GitHub (Feb 13, 2023):
@alexaka1 could you send me an email and let me know one of your aliases so I can test this when you reply?