starred/alley-oop
1
0
Fork 0
mirror of https://github.com/futurice/alley-oop.git synced 2026-04-25 14:35:54 +03:00
Code Issues 1 Projects Releases 5 Packages Wiki Activity

[PR #7] [CLOSED] Update autocert to support ACMEv2 #9

New issue
Closed
opened 2026-03-04 14:56:13 +03:00 by kerem · 0 comments
kerem commented 2026-03-04 14:56:13 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/futurice/alley-oop/pull/7
Author: @sevesalm
Created: 5/18/2020
Status: ❌ Closed

Base: master ← Head: update-autocert

📝 Commits (5)

  • fd64757 Update autocert package
  • ee5634b Update Docker files
  • 03a615a Update axios version to get rid of vulnerability
  • 54f10b6 Add configuration for email
  • 8c03231 Update imports

📊 Changes

15 files changed (+1810 additions, -368 deletions)

View changed files

📝 demo/package.json (+1 -1)
📝 src/Dockerfile (+2 -2)
📝 src/autocert/autocert.go (+434 -193)
📝 src/autocert/autocert_test.go (+595 -120)
📝 src/autocert/cache.go (+10 -4)
📝 src/autocert/cache_test.go (+9 -0)
📝 src/autocert/example_test.go (+2 -4)
➕ src/autocert/internal/acmetest/ca.go (+552 -0)
📝 src/autocert/listener.go (+1 -6)
📝 src/autocert/renewal.go (+31 -14)
📝 src/autocert/renewal_test.go (+161 -20)
📝 src/config/config.cfg (+2 -0)
📝 src/docker-compose.yml (+1 -1)
📝 src/main.go (+1 -0)
📝 src/types.go (+8 -3)

📄 Description

  • update the autocert files to the latest ones from https://github.com/golang/crypto/tree/master/acme/autocert to support ACMEv2
  • update Go compiler to a more recent version (should be 100% backwards compatible, and the code compiles fine)
  • fix the docker image to point the the ACMEv1 version (for now) so that when I release a new image for testing, old one is still used as a default
  • add a way to config the email for let's encrypt notification emails

Next steps:

  1. Make a alpha release Cocker image of this (previous version will be intact)
  2. Deploy the image on UAT for testing
  3. If all goes well, deploy to LIVE.

PS. Don't spend too much time reviewing the autocert code. I didn't either...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/futurice/alley-oop/pull/7 **Author:** [@sevesalm](https://github.com/sevesalm) **Created:** 5/18/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `update-autocert` --- ### 📝 Commits (5) - [`fd64757`](https://github.com/futurice/alley-oop/commit/fd6475736a9f7e21184163673c5602447a1d785f) Update autocert package - [`ee5634b`](https://github.com/futurice/alley-oop/commit/ee5634b71c4e1e5e89899d29da6be7744ae0412f) Update Docker files - [`03a615a`](https://github.com/futurice/alley-oop/commit/03a615ad701d9b35d08789d33f177e439b5bd2c6) Update axios version to get rid of vulnerability - [`54f10b6`](https://github.com/futurice/alley-oop/commit/54f10b689ddfc96c3f6324f993365a8408513e9a) Add configuration for email - [`8c03231`](https://github.com/futurice/alley-oop/commit/8c0323148dcbdd759a87e134ee7201b11dca5df7) Update imports ### 📊 Changes **15 files changed** (+1810 additions, -368 deletions) <details> <summary>View changed files</summary> 📝 `demo/package.json` (+1 -1) 📝 `src/Dockerfile` (+2 -2) 📝 `src/autocert/autocert.go` (+434 -193) 📝 `src/autocert/autocert_test.go` (+595 -120) 📝 `src/autocert/cache.go` (+10 -4) 📝 `src/autocert/cache_test.go` (+9 -0) 📝 `src/autocert/example_test.go` (+2 -4) ➕ `src/autocert/internal/acmetest/ca.go` (+552 -0) 📝 `src/autocert/listener.go` (+1 -6) 📝 `src/autocert/renewal.go` (+31 -14) 📝 `src/autocert/renewal_test.go` (+161 -20) 📝 `src/config/config.cfg` (+2 -0) 📝 `src/docker-compose.yml` (+1 -1) 📝 `src/main.go` (+1 -0) 📝 `src/types.go` (+8 -3) </details> ### 📄 Description - update the autocert files to the latest ones from https://github.com/golang/crypto/tree/master/acme/autocert to support ACMEv2 - update Go compiler to a more recent version (should be 100% backwards compatible, and the code compiles fine) - fix the docker image to point the the ACMEv1 version (for now) so that when I release a new image for testing, old one is still used as a default - add a way to config the email for let's encrypt notification emails Next steps: 1. Make a alpha release Cocker image of this (previous version will be intact) 1. Deploy the image on UAT for testing 1. If all goes well, deploy to LIVE. PS. Don't spend too much time reviewing the autocert code. I didn't either... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 14:56:13 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
update-autocert
v2.0.0
v2.0.0-alpha.1
v1.1.2
v1.1.1
v1.1.0
v1.0.0
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/alley-oop#9
No description provided.