[PR #8] [MERGED] Update autocert with ACMv2 and dns-01 challenge support #11

Closed
opened 2026-03-04 14:56:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/futurice/alley-oop/pull/8
Author: @sevesalm
Created: 6/4/2020
Status: Merged
Merged: 6/8/2020
Merged by: @sevesalm

Base: masterHead: update-autocert-with-dns-01


📝 Commits (9)

📊 Changes

14 files changed (+1867 additions, -380 deletions)

View changed files

📝 README.md (+42 -39)
📝 demo/package.json (+2 -2)
📝 src/Dockerfile (+2 -2)
📝 src/api.go (+11 -5)
📝 src/autocert/autocert.go (+448 -163)
📝 src/autocert/autocert_test.go (+595 -120)
📝 src/autocert/cache.go (+10 -4)
📝 src/autocert/cache_test.go (+9 -0)
📝 src/autocert/example_test.go (+2 -4)
src/autocert/internal/acmetest/ca.go (+552 -0)
📝 src/autocert/listener.go (+1 -6)
📝 src/autocert/renewal.go (+31 -14)
📝 src/autocert/renewal_test.go (+161 -20)
📝 src/main.go (+1 -1)

📄 Description

Ok, a better try this time:

  • autocert package has been updated to support ACMEv2
  • dns-01 challenge was added from the old autocert version (no idea why they have removed it)
  • error logging has been improved: ACME errors are now returned to the caller of alley-oop API
  • some packages updated

A version with these updates is already running on UAT and LIVE and seems to work. I'll reprovision once more once this gets in to make sure that updating the docker hub image works properly.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/futurice/alley-oop/pull/8 **Author:** [@sevesalm](https://github.com/sevesalm) **Created:** 6/4/2020 **Status:** ✅ Merged **Merged:** 6/8/2020 **Merged by:** [@sevesalm](https://github.com/sevesalm) **Base:** `master` ← **Head:** `update-autocert-with-dns-01` --- ### 📝 Commits (9) - [`cbd175a`](https://github.com/futurice/alley-oop/commit/cbd175aaee1d07dc71841c7ebc354c91d8d63dbb) Update autocert package from upstream - [`ee92985`](https://github.com/futurice/alley-oop/commit/ee9298598a95c9ade8c3498dd4876124c5a7aa56) Add dns-01 support - [`344837f`](https://github.com/futurice/alley-oop/commit/344837f23cad981610f877adea157ec14f2e031e) Improve logging - [`504cef7`](https://github.com/futurice/alley-oop/commit/504cef7b387786ed6a3f95144665bbd7486777fd) Prettify README - [`c24a1ea`](https://github.com/futurice/alley-oop/commit/c24a1eade36e1eacabce29e67412535dd6842cfc) Update image versions - [`65b7979`](https://github.com/futurice/alley-oop/commit/65b79793be538534514fc18a36fc3f6d7ac10d7c) Update axios to get rid of a vulnerability - [`d3c7637`](https://github.com/futurice/alley-oop/commit/d3c7637fb6ad81d9105be6741c7760057c4ba3c9) Update alley-oop version to 2 - [`aab148f`](https://github.com/futurice/alley-oop/commit/aab148f3523cd1e6aa0e9d0ede56c0873b5540fa) Update README - [`b28c958`](https://github.com/futurice/alley-oop/commit/b28c9583d2e61137465dc76fb0ede03cf8b77000) Update imports ### 📊 Changes **14 files changed** (+1867 additions, -380 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+42 -39) 📝 `demo/package.json` (+2 -2) 📝 `src/Dockerfile` (+2 -2) 📝 `src/api.go` (+11 -5) 📝 `src/autocert/autocert.go` (+448 -163) 📝 `src/autocert/autocert_test.go` (+595 -120) 📝 `src/autocert/cache.go` (+10 -4) 📝 `src/autocert/cache_test.go` (+9 -0) 📝 `src/autocert/example_test.go` (+2 -4) ➕ `src/autocert/internal/acmetest/ca.go` (+552 -0) 📝 `src/autocert/listener.go` (+1 -6) 📝 `src/autocert/renewal.go` (+31 -14) 📝 `src/autocert/renewal_test.go` (+161 -20) 📝 `src/main.go` (+1 -1) </details> ### 📄 Description Ok, a better try this time: - autocert package has been updated to support ACMEv2 - `dns-01` challenge was added from the old autocert version (no idea why they have removed it) - error logging has been improved: ACME errors are now returned to the caller of `alley-oop` API - some packages updated A version with these updates is already running on UAT and LIVE and seems to work. I'll reprovision once more once this gets in to make sure that updating the docker hub image works properly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 14:56:14 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/alley-oop#11
No description provided.