[PR #33] [MERGED] Fixes for Invalid Index errors. #46

New issue

Closed

opened 2026-03-02 23:33:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:33:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/airmessage/airmessage-server/pull/33
Author: @j4byers
Created: 9/16/2022
Status: ✅ Merged
Merged: 9/18/2022
Merged by: @tagavari

Base: main ← Head: main

📝 Commits (3)

8160e07 Fixes for Invalid Index Errors on Incoming Calls
5a98637 Fixes Detection of Incoming Call (Looks for "FaceTime Video" in Notification)
1c3e52e Remove redundant lines and fix indents.

📊 Changes

6 files changed (+59 additions, -35 deletions)

View changed files

📝 AirMessage/AppleScript/AppleScriptSource/FaceTime/acceptPendingUser.applescript (+9 -5)
📝 AirMessage/AppleScript/AppleScriptSource/FaceTime/getActiveLink.applescript (+20 -11)
📝 AirMessage/AppleScript/AppleScriptSource/FaceTime/getNewLink.applescript (+7 -5)
📝 AirMessage/AppleScript/AppleScriptSource/FaceTime/initiateOutgoingCall.applescript (+15 -8)
📝 AirMessage/AppleScript/AppleScriptSource/FaceTime/leaveCall.applescript (+7 -5)
📝 AirMessage/AppleScript/AppleScriptSource/FaceTime/queryIncomingCall.applescript (+1 -1)

📄 Description

@tagavari Hey, I replied to you on Discord -- these are the fixes that have eliminated those AppleScript Invalid Index errors for me. Basically makes use of some repeat loops to detect the presence of the buttons we're looking for, and uses try catch exceptions to prevent stopping on irrelevant errors.

In the future, I might try speeding up the execution of these scripts by replacing some of the arbitrary delays with similar loops.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/airmessage/airmessage-server/pull/33 **Author:** [@j4byers](https://github.com/j4byers) **Created:** 9/16/2022 **Status:** ✅ Merged **Merged:** 9/18/2022 **Merged by:** [@tagavari](https://github.com/tagavari) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`8160e07`](https://github.com/airmessage/airmessage-server/commit/8160e07c69f9dabce8a8129eca78c486f549d105) Fixes for Invalid Index Errors on Incoming Calls - [`5a98637`](https://github.com/airmessage/airmessage-server/commit/5a986376d91227755867b88beebe843da0271b04) Fixes Detection of Incoming Call (Looks for "FaceTime Video" in Notification) - [`1c3e52e`](https://github.com/airmessage/airmessage-server/commit/1c3e52e17c7604bca92d8d7f9e76bb164400750c) Remove redundant lines and fix indents. ### 📊 Changes **6 files changed** (+59 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `AirMessage/AppleScript/AppleScriptSource/FaceTime/acceptPendingUser.applescript` (+9 -5) 📝 `AirMessage/AppleScript/AppleScriptSource/FaceTime/getActiveLink.applescript` (+20 -11) 📝 `AirMessage/AppleScript/AppleScriptSource/FaceTime/getNewLink.applescript` (+7 -5) 📝 `AirMessage/AppleScript/AppleScriptSource/FaceTime/initiateOutgoingCall.applescript` (+15 -8) 📝 `AirMessage/AppleScript/AppleScriptSource/FaceTime/leaveCall.applescript` (+7 -5) 📝 `AirMessage/AppleScript/AppleScriptSource/FaceTime/queryIncomingCall.applescript` (+1 -1) </details> ### 📄 Description @tagavari Hey, I replied to you on Discord -- these are the fixes that have eliminated those AppleScript Invalid Index errors for me. Basically makes use of some repeat loops to detect the presence of the buttons we're looking for, and uses try catch exceptions to prevent stopping on irrelevant errors. In the future, I might try speeding up the execution of these scripts by replacing some of the arbitrary delays with similar loops. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>