mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[GH-ISSUE #795] Actions Container image is misinterpreted when using own registry with short oci url #493
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#493
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FloThinksPi on GitHub (Sep 1, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/795
Originally assigned to: @catthehacker on GitHub.
System information
actversion: act version 0.2.24Expected behaviour
Pulls the correct image
Actual behaviour
Adds docker.io to the image which already has a private repo specified and thus the url is invalid.
Workflow and/or repository
workflow
Steps to reproduce
Create workflow with custom container image in job step(see workflow file above).
Watch pull fail.
actoutputIf i just do a act without verbose i get:
So image pull URL looks fine.
However if i do act -vvv on the same workflow i get:
So here one can see it puts a docker.io in front of the already complete OCI Resource URL.
Then it fails as this obviously is not allowed.
@FloThinksPi commented on GitHub (Sep 1, 2021):
It seems to work if i use:
myrepo:50000/library/ubuntu:20.04Then the correct image is pulled.
I think act has some logic in it that interprets
myrepo:50000/ubuntu:20.04asmyrepo:50000beeing the username andubuntubeeing the image and20.04beeing the tag. So it appends docker.io as registry url then.However Docker pull on
myrepo:50000/ubuntu:20.04works as expected though and pulls the right image(which long url would bemyrepo:50000/library/ubuntu:20.04). So i think it is actually wanted to pull the image that the container runtime would pull. So to interpretmyrepo:50000as url and not as username in that case.@catthehacker commented on GitHub (Sep 1, 2021):
github.com/nektos/act@6e5bd24728/pkg/container/docker_pull.go (L100-L109)@github-actions[bot] commented on GitHub (Oct 2, 2021):
Issue is stale and will be closed in 14 days unless there is new activity
@catthehacker commented on GitHub (Oct 2, 2021):
Not stale, will fix that this weekend
@github-actions[bot] commented on GitHub (Nov 2, 2021):
Issue is stale and will be closed in 14 days unless there is new activity