starred/act
1
0
Fork 0
mirror of https://github.com/nektos/act.git synced 2026-04-26 01:15:51 +03:00
Code Issues 289 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #765] Issue: better contributing documentation for act #483

New issue
Closed
opened 2026-03-01 21:43:47 +03:00 by kerem · 11 comments
kerem commented 2026-03-01 21:43:47 +03:00
Owner
Copy link

Originally created by @ryuheechul on GitHub (Aug 6, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/765

Originally assigned to: @catthehacker on GitHub.

System information

  • Operating System: macOS
  • Architecture: arm64
  • Apple M1: yes but running tests with go amd64 version with Rosetta
  • Docker version: 20.10.7
  • Docker image used in act: N/A
  • act version: main branch, github.com/nektos/act@0ff204b615

Expected behaviour

go test ./... run successfully

Actual behaviour

Many test files fail including
github.com/nektos/act@0ff204b615/pkg/runner/step_context_test.go

Workflow and/or repository

N/A

Steps to reproduce

Either make test or go test ./...

act output

N/A

Description

It looks like many tests are broken? including github.com/nektos/act@0ff204b615/pkg/runner/step_context_test.go (L1-L29)

❯ go test ./pkg/runner/step_context_test.go
# command-line-arguments [command-line-arguments.test]
pkg/runner/step_context_test.go:12:20: undefined: baseImage
pkg/runner/step_context_test.go:14:14: undefined: TestJobFileInfo
pkg/runner/step_context_test.go:27:3: undefined: runTestJobFile
FAIL    command-line-arguments [build failed]
FAIL

And indeed the file misses most of references.
just curious, if test files and testing is being ignored in the process of development?

Why raise this issue?

I tried to see if I could contribute to resolve this issue, https://github.com/nektos/act/issues/739
And I just cloned act for the first time and I find that not being able to run tests difficult to continue. Hence, became curious to see what's the stance of tests for this code/repository.

Originally created by @ryuheechul on GitHub (Aug 6, 2021). Original GitHub issue: https://github.com/nektos/act/issues/765 Originally assigned to: @catthehacker on GitHub. <!-- - Make sure you are able to reproduce it on the [latest version](https://github.com/nektos/act/releases) - Search the existing issues. - Refer to [README](https://github.com/nektos/act/blob/master/README.md). --> ## System information <!-- - Operating System: < Windows | Linux | macOS | etc... > - Architecture: < x64 (64-bit) | x86 (32-bit) | arm64 (64-bit) | arm (32-bit) | etc... > - Apple M1: < yes | no > - Docker version: < output of `docker system info -f "{{.ServerVersion}}"` > - Docker image used in `act`: < can be omitted if it's included in log > - `act` version: < output of `act --version`, if you've built `act` yourself, please provide commit hash > --> - Operating System: macOS - Architecture: arm64 - Apple M1: yes but running tests with go amd64 version with Rosetta - Docker version: 20.10.7 - Docker image used in `act`: N/A - `act` version: main branch, https://github.com/nektos/act/commit/0ff204b61523b0137d41c4479a132fde87211327 ## Expected behaviour `go test ./...` run successfully <!-- - Describe how whole process should go and finish --> ## Actual behaviour <!-- - Describe the issue --> Many test files fail including https://github.com/nektos/act/blob/0ff204b61523b0137d41c4479a132fde87211327/pkg/runner/step_context_test.go ## Workflow and/or repository <!-- - Provide workflow with which we can reproduce the issue OR - Provide link to your GitHub repository that contains the workflow --> N/A ## Steps to reproduce <!-- - Make sure to include full command with parameters you used to run `act`, example: 1. Clone example repo (https://github.com/cplee/github-actions-demo) 2. Enter cloned repo directory 3. Run `act -s SUPER_SECRET=im-a-value` --> Either `make test` or `go test ./...` ## `act` output <!-- - Use `act` with `-v`/`--verbose` and paste output from your terminal in code block below --> N/A ## Description It looks like many tests are broken? including https://github.com/nektos/act/blob/0ff204b61523b0137d41c4479a132fde87211327/pkg/runner/step_context_test.go#L1-L29 ``` ❯ go test ./pkg/runner/step_context_test.go # command-line-arguments [command-line-arguments.test] pkg/runner/step_context_test.go:12:20: undefined: baseImage pkg/runner/step_context_test.go:14:14: undefined: TestJobFileInfo pkg/runner/step_context_test.go:27:3: undefined: runTestJobFile FAIL command-line-arguments [build failed] FAIL ``` And indeed the file misses most of references. just curious, if test files and testing is being ignored in the process of development? ### Why raise this issue? I tried to see if I could contribute to resolve this issue, https://github.com/nektos/act/issues/739 And I just cloned `act` for the first time and I find that not being able to run tests difficult to continue. Hence, became curious to see what's the stance of tests for this code/repository.
kerem 2026-03-01 21:43:47 +03:00
kerem commented 2026-03-01 21:43:48 +03:00
Author
Owner
Copy link

@ChristopherHX commented on GitHub (Aug 6, 2021):

They are working for me in my ide.

if test files and testing is being ignored in the process of development

All Tests are still required to succeed on linux and macOS, otherwise a PR will not be merged.

I'm using vscode + go tools, make shure you have go 1.16 and no older version.
I opened ./pkg/runner/step_context_test.go and pressed debug test ( a button over the test function added by the go tools for vscode).

go test ./pkg/runner/step_context_test.go fails with the same error on my windows machine, I guess this is not the right way to run a test.

  • You can also open the action tab of your fork
  • enable actions, you can keep "Close stale issues" and "release" disabled
  • select checks
  • press run workflow
  • select the branch with your changes
  • you will see your tests running on github

I hate the macOS Test suite for this project, becauses it fails far to often due to docker hub rate limits

<!-- gh-comment-id:894533053 --> @ChristopherHX commented on GitHub (Aug 6, 2021): They are working for me in my ide. > if test files and testing is being ignored in the process of development All Tests are still required to succeed on linux and macOS, otherwise a PR will not be merged. I'm using [vscode](https://code.visualstudio.com/) + [go tools](https://marketplace.visualstudio.com/items?itemName=golang.go), make shure you have go 1.16 and no older version. I opened ./pkg/runner/step_context_test.go and pressed `debug test` ( a button over the test function added by the go tools for vscode). `go test ./pkg/runner/step_context_test.go` fails with the same error on my windows machine, I guess this is not the right way to run a test. - You can also open the action tab of your fork - enable actions, you can keep "Close stale issues" and "release" disabled - select checks - press run workflow - select the branch with your changes - you will see your tests running on github _I hate the macOS Test suite for this project, becauses it fails far to often due to docker hub rate limits_
kerem commented 2026-03-01 21:43:48 +03:00
Author
Owner
Copy link

@catthehacker commented on GitHub (Aug 6, 2021):

Not sure what you mean, go test ./... runs successfully and you provided example of running single test file which does not include required variable.
github.com/nektos/act@0ff204b615/pkg/runner/runner_test.go (L19-L25)

just curious, if test files and testing is being ignored in the process of development?

no, they are not

<!-- gh-comment-id:894541785 --> @catthehacker commented on GitHub (Aug 6, 2021): Not sure what you mean, `go test ./...` runs successfully and you provided example of running single test file which does not include required variable. https://github.com/nektos/act/blob/0ff204b61523b0137d41c4479a132fde87211327/pkg/runner/runner_test.go#L19-L25 > just curious, if test files and testing is being ignored in the process of development? no, they are not
kerem commented 2026-03-01 21:43:48 +03:00
Author
Owner
Copy link

@catthehacker commented on GitHub (Aug 6, 2021):

  • Apple M1: yes but running tests with go amd64 version with Rosetta

You should be using arm64 version of Go

<!-- gh-comment-id:894545161 --> @catthehacker commented on GitHub (Aug 6, 2021): > * Apple M1: yes but running tests with go amd64 version with Rosetta You should be using arm64 version of Go
kerem commented 2026-03-01 21:43:48 +03:00
Author
Owner
Copy link

@ryuheechul commented on GitHub (Aug 6, 2021):

Thanks all for prompt responses!

I just figured out that go test ./pkg/runner/step_context_test.go is a wrong usage of testing in Go.
So I tried go test ./pkg/runner instead. Now no more the same issue (undefined ...) but failing with some other issues.

Since you all having no issues with running tests, something must have been wrong with my setup or I'm doing something wrong. I will try this later (maybe with an intel mac) and share my results.

Have a good weekend everyone :)

<!-- gh-comment-id:894553188 --> @ryuheechul commented on GitHub (Aug 6, 2021): Thanks all for prompt responses! I just figured out that `go test ./pkg/runner/step_context_test.go` is a wrong usage of testing in Go. So I tried `go test ./pkg/runner` instead. Now no more the same issue (`undefined ...`) but failing with some other issues. Since you all having no issues with running tests, something must have been wrong with my setup or I'm doing something wrong. I will try this later (maybe with an intel mac) and share my results. Have a good weekend everyone :)
kerem commented 2026-03-01 21:43:49 +03:00
Author
Owner
Copy link

@catthehacker commented on GitHub (Aug 7, 2021):

I just figured out that go test ./pkg/runner/step_context_test.go is a wrong usage of testing in Go.

well, it's not wrong usage in Go, just wrong in this project, depends if test depend on whole package or just file

<!-- gh-comment-id:894574288 --> @catthehacker commented on GitHub (Aug 7, 2021): > I just figured out that `go test ./pkg/runner/step_context_test.go` is a wrong usage of testing in Go. well, it's not wrong usage in Go, just wrong in this project, depends if test depend on whole package or just file
kerem commented 2026-03-01 21:43:49 +03:00
Author
Owner
Copy link

@catthehacker commented on GitHub (Aug 7, 2021):

I guess the issue is solved so I'm going to close it. Ping me here or on Gitter if you still have issues.

I hate the macOS Test suite for this project, becauses it fails far to often due to docker hub rate limits

Please direct your hate towards Apple/Docker for having shitty licencing :) (because of that, docker can't be included in GitHub Actions runners and therefore special API keys for bypassing rate limits are not included like in ubuntu runners)

<!-- gh-comment-id:894625029 --> @catthehacker commented on GitHub (Aug 7, 2021): I guess the issue is solved so I'm going to close it. Ping me here or on Gitter if you still have issues. > I hate the macOS Test suite for this project, becauses it fails far to often due to docker hub rate limits Please direct your hate towards Apple/Docker for having shitty licencing :) (because of that, `docker` can't be included in GitHub Actions runners and therefore special API keys for bypassing rate limits are not included like in `ubuntu` runners)
kerem commented 2026-03-01 21:43:49 +03:00
Author
Owner
Copy link

@ryuheechul commented on GitHub (Aug 7, 2021):

Thanks @catthehacker 👍🏼
I agree with closing the issue.
I can see that tests are running here fine, https://github.com/nektos/act/actions/runs/1094834668 (most recent tests)
(I should have found this one before opening the issue little too quickly!)

I understand macOS can be tricky to evaluate the build and test so I also tried with Github Codespace (Linux).
However, make test still failing on it and here are some pieces of error messeages from it.
(ran it multiple times for both master branch and most recent tag, 0.2.24)

--- FAIL: TestRunEventPullRequest (1.26s)
    runner_test.go:210: 
                Error Trace:    runner_test.go:210
                Error:          Expected nil, but got: Error response from daemon: Container 17f375729f595ddbc0aac432e7e1244911c54b277ebb90ff7e38926ee6b5ec03 is not running
                Test:           TestRunEventPullRequest
                Messages:       pull-request

...

*DRYRUN* [uses-github-root/test]   ❌  Failure - actions/hello-world-docker-action@b136eb8
time="2021-08-07T09:16:14Z" level=debug msg="b136eb8894c5cb1dd5807da824be97ccdf9b5423\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\nshort SHA references are not supported\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371"
FAIL
FAIL    github.com/nektos/act/pkg/runner        60.106s
FAIL
make: *** [Makefile:31: test] Error 1

It's probably related to docker issue and I'm not intending to reopen this issue.
Simply just wanted to share what I saw just now.

<!-- gh-comment-id:894632110 --> @ryuheechul commented on GitHub (Aug 7, 2021): Thanks @catthehacker 👍🏼 I agree with closing the issue. I can see that tests are running here fine, https://github.com/nektos/act/actions/runs/1094834668 (most recent tests) (I should have found this one before opening the issue little too quickly!) I understand macOS can be tricky to evaluate the build and test so I also tried with Github Codespace (Linux). However, `make test` still failing on it and here are some pieces of error messeages from it. (ran it multiple times for both `master` branch and most recent tag, `0.2.24`) ``` --- FAIL: TestRunEventPullRequest (1.26s) runner_test.go:210: Error Trace: runner_test.go:210 Error: Expected nil, but got: Error response from daemon: Container 17f375729f595ddbc0aac432e7e1244911c54b277ebb90ff7e38926ee6b5ec03 is not running Test: TestRunEventPullRequest Messages: pull-request ... *DRYRUN* [uses-github-root/test] ❌ Failure - actions/hello-world-docker-action@b136eb8 time="2021-08-07T09:16:14Z" level=debug msg="b136eb8894c5cb1dd5807da824be97ccdf9b5423\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\nshort SHA references are not supported\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371" FAIL FAIL github.com/nektos/act/pkg/runner 60.106s FAIL make: *** [Makefile:31: test] Error 1 ``` It's probably related to docker issue and I'm not intending to reopen this issue. Simply just wanted to share what I saw just now.
kerem commented 2026-03-01 21:43:49 +03:00
Author
Owner
Copy link

@catthehacker commented on GitHub (Aug 7, 2021):

I understand macOS can be tricky to evaluate the build and test so I also tried with Github Codespace (Linux).
However, make test still failing on it and here are some pieces of error messeages from it.
(ran it multiple times for both master branch and most recent tag, 0.2.24)

--- FAIL: TestRunEventPullRequest (1.26s)
    runner_test.go:210: 
                Error Trace:    runner_test.go:210
                Error:          Expected nil, but got: Error response from daemon: Container 17f375729f595ddbc0aac432e7e1244911c54b277ebb90ff7e38926ee6b5ec03 is not running
                Test:           TestRunEventPullRequest
                Messages:       pull-request

...

*DRYRUN* [uses-github-root/test]   ❌  Failure - actions/hello-world-docker-action@b136eb8
time="2021-08-07T09:16:14Z" level=debug msg="b136eb8894c5cb1dd5807da824be97ccdf9b5423\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\nshort SHA references are not supported\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371"
FAIL
FAIL    github.com/nektos/act/pkg/runner        60.106s
FAIL
make: *** [Makefile:31: test] Error 1

It's probably related to docker issue and I'm not intending to reopen this issue.
Simply just wanted to share what I saw just now.

@ryuheechul
That's my fault on not documenting it and/or isolating but we test running different architecture container (tests run with linux/amd64 + one single test case runs linux/arm64 [if ran on amd64, if ran on arm64, everything will run as arm64])
You need to run docker run --privileged --rm tonistiigi/binfmt --install all or docker run --privileged --rm tonistiigi/binfmt --install amd64,arm64 and re-run tests

<!-- gh-comment-id:894632562 --> @catthehacker commented on GitHub (Aug 7, 2021): > I understand macOS can be tricky to evaluate the build and test so I also tried with Github Codespace (Linux). > However, `make test` still failing on it and here are some pieces of error messeages from it. > (ran it multiple times for both `master` branch and most recent tag, `0.2.24`) > > ``` > --- FAIL: TestRunEventPullRequest (1.26s) > runner_test.go:210: > Error Trace: runner_test.go:210 > Error: Expected nil, but got: Error response from daemon: Container 17f375729f595ddbc0aac432e7e1244911c54b277ebb90ff7e38926ee6b5ec03 is not running > Test: TestRunEventPullRequest > Messages: pull-request > > ... > > *DRYRUN* [uses-github-root/test] ❌ Failure - actions/hello-world-docker-action@b136eb8 > time="2021-08-07T09:16:14Z" level=debug msg="b136eb8894c5cb1dd5807da824be97ccdf9b5423\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\nshort SHA references are not supported\ngithub.com/nektos/act/pkg/common.NewGitCloneExecutor.func1\n\t/workspaces/act/pkg/common/git.go:316\ngithub.com/nektos/act/pkg/runner.(*StepContext).Executor\n\t/workspaces/act/pkg/runner/step_context.go:110\ngithub.com/nektos/act/pkg/runner.(*RunContext).newStepExecutor.func1\n\t/workspaces/act/pkg/runner/run_context.go:265\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:146\ngithub.com/nektos/act/pkg/common.Executor.Then.func1\n\t/workspaces/act/pkg/common/executor.go:133\ngithub.com/nektos/act/pkg/common.Executor.If.func1\n\t/workspaces/act/pkg/common/executor.go:154\ngithub.com/nektos/act/pkg/common.Executor.Finally.func1\n\t/workspaces/act/pkg/common/executor.go:180\ngithub.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1\n\t/workspaces/act/pkg/runner/runner.go:145\ngithub.com/nektos/act/pkg/common.Executor.ChannelError.func1\n\t/workspaces/act/pkg/common/executor.go:125\ngithub.com/nektos/act/pkg/common.NewParallelExecutor.func1.1\n\t/workspaces/act/pkg/common/executor.go:101\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371" > FAIL > FAIL github.com/nektos/act/pkg/runner 60.106s > FAIL > make: *** [Makefile:31: test] Error 1 > ``` > > It's probably related to docker issue and I'm not intending to reopen this issue. > Simply just wanted to share what I saw just now. @ryuheechul That's my fault on not documenting it and/or isolating but we test running different architecture container (tests run with `linux/amd64` + one single test case runs `linux/arm64` [if ran on amd64, if ran on arm64, everything will run as arm64]) You need to run `docker run --privileged --rm tonistiigi/binfmt --install all` or `docker run --privileged --rm tonistiigi/binfmt --install amd64,arm64` and re-run tests
kerem commented 2026-03-01 21:43:49 +03:00
Author
Owner
Copy link

@ryuheechul commented on GitHub (Aug 7, 2021):

@catthehacker Cool and thanks!

So I ran it on Github Codespace and all tests have passed 👍🏼

$ docker run --privileged --rm tonistiigi/binfmt --install amd64,arm64
Unable to find image 'tonistiigi/binfmt:latest' locally
latest: Pulling from tonistiigi/binfmt
a5644ca467e1: Pull complete 
6f3748a79141: Pull complete 
Digest: sha256:ce4d5a2a6ac4a189047fca2d71cbd901cc7beebacf538be95fccb3aca87cb2ec
Status: Downloaded newer image for tonistiigi/binfmt:latest
installing: amd64 cannot write to /proc/sys/fs/binfmt_misc/register: write /proc/sys/fs/binfmt_misc/register: no such file or directory
installing: arm64 OK
{
  "supported": [
    "linux/amd64",
    "linux/arm64",
    "linux/386"
  ],
  "emulators": [
    "qemu-aarch64"
  ]
}

$ go test ./...
?       github.com/nektos/act   [no test files]
?       github.com/nektos/act/cmd       [no test files]
ok      github.com/nektos/act/pkg/common        (cached)
ok      github.com/nektos/act/pkg/container     (cached)
ok      github.com/nektos/act/pkg/model (cached)
ok      github.com/nektos/act/pkg/runner        111.241s
<!-- gh-comment-id:894692470 --> @ryuheechul commented on GitHub (Aug 7, 2021): @catthehacker Cool and thanks! So I ran it on Github Codespace and all tests have passed 👍🏼 ``` $ docker run --privileged --rm tonistiigi/binfmt --install amd64,arm64 Unable to find image 'tonistiigi/binfmt:latest' locally latest: Pulling from tonistiigi/binfmt a5644ca467e1: Pull complete 6f3748a79141: Pull complete Digest: sha256:ce4d5a2a6ac4a189047fca2d71cbd901cc7beebacf538be95fccb3aca87cb2ec Status: Downloaded newer image for tonistiigi/binfmt:latest installing: amd64 cannot write to /proc/sys/fs/binfmt_misc/register: write /proc/sys/fs/binfmt_misc/register: no such file or directory installing: arm64 OK { "supported": [ "linux/amd64", "linux/arm64", "linux/386" ], "emulators": [ "qemu-aarch64" ] } ``` ``` $ go test ./... ? github.com/nektos/act [no test files] ? github.com/nektos/act/cmd [no test files] ok github.com/nektos/act/pkg/common (cached) ok github.com/nektos/act/pkg/container (cached) ok github.com/nektos/act/pkg/model (cached) ok github.com/nektos/act/pkg/runner 111.241s ```
kerem commented 2026-03-01 21:43:49 +03:00
Author
Owner
Copy link

@ryuheechul commented on GitHub (Aug 7, 2021):

Anyone also didn't know what binfmt[_misc] was (just like me), you can read about it in the link below and it's quite fascinating.
https://medium.com/@tonistiigi/early-look-at-docker-containers-on-risc-v-40ed43b16b09

<!-- gh-comment-id:894695824 --> @ryuheechul commented on GitHub (Aug 7, 2021): Anyone also didn't know what `binfmt[_misc]` was (just like me), you can read about it in the link below and it's quite fascinating. https://medium.com/@tonistiigi/early-look-at-docker-containers-on-risc-v-40ed43b16b09
kerem commented 2026-03-01 21:43:49 +03:00
Author
Owner
Copy link

@catthehacker commented on GitHub (Aug 7, 2021):

I'm going to hijack this issue to improve docs.

<!-- gh-comment-id:894707557 --> @catthehacker commented on GitHub (Aug 7, 2021): I'm going to hijack this issue to improve docs.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/github.com/go-git/go-git/v5-5.18.0
dependabot/go_modules/dependencies-08815e2262
mergify/configuration-deprecated-update
dependabot/github_actions/dependencies-a3a104477f
chore/simplify-ci-and-makefile
dependabot/go_modules/golang.org/x/crypto-0.45.0
dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0
panekj/ci/improve-jobs
fix-skip-non-yaml-files-in-dir
normalize-pull-rebuild-flags
fix-no-recurse-by-default
2517-poor-error-for-incomplete-action-step
2472-make-use-new-action-cache-the-new-default-for-downloading-actions
act-tart
act-lxc
act-oidc
act-dind
avoid-slash-in-actor
dependabot/go_modules/github.com/docker/docker-26.1.4incompatible
meta-keep-filetime
local-repository-action-cache
pr-merger
update-docker-deps
follow_local_action_symlink
boltdb-lock-in-handler
use-socket-path
no-pull-no-rebuild
path-issues
fix/env
feat/podman
refactor/testdata
v0.2.87
v0.2.86
v0.2.85
v0.2.84
v0.2.83
v0.2.82
v0.2.81
v0.2.80
v0.2.79
v0.2.78
v0.2.77
v0.2.76
v0.2.75
v0.2.74
v0.2.73
v0.2.72
v0.2.71
v0.2.70
v0.2.69
v0.2.68
v0.2.67
v0.2.66
v0.2.65
v0.2.64
v0.2.63
v0.2.62
v0.2.61
v0.2.60
v0.2.59
v0.2.58
v0.2.57
v0.2.56
v0.2.55
v0.2.54
v0.2.53
v0.2.52
v0.2.51
v0.2.50
v0.2.49
v0.2.48
v0.2.47
v0.2.46
v0.2.45
v0.2.44
v0.2.43
v0.2.42
v0.2.41
v0.2.40
v0.2.39
v0.2.38
v0.2.37
v0.2.36
v0.2.35
v0.2.34
v0.2.33
v0.2.32
v0.2.31
v0.2.30
v0.2.29
v0.2.28
v0.2.27
v0.2.26
v0.2.25
v0.2.24
v0.2.23
v0.2.22
v0.2.21
v0.2.20
v0.2.19
v0.2.18
v0.2.17
v0.2.16
v0.2.15
v0.2.14
v0.2.13
v0.2.12
v0.2.11
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
area/action

   
area/cli

   
area/docs

   
area/image

   
area/runner

   
area/workflow

   
backlog

   
confirmed/not-planned

   
kind/bug

   
kind/discussion

   
kind/external

   
kind/feature-request

   
kind/question

   
meta/duplicate

   
meta/invalid

   
meta/need-more-info

   
meta/resolved

   
meta/wontfix

   
meta/workaround

   
needs-work

   
pull-request

Mirrored from GitHub Pull Request

  
review/not-planned

   
size/M

   
size/XL

   
size/XXL

   
stale

   
stale-exempt
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#483
No description provided.