[GH-ISSUE #769] Issue: Matrix construction does not match GitHub #481

New issue

Closed

opened 2026-03-01 21:43:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:43:47 +03:00

Owner

Originally created by @catthehacker on GitHub (Aug 8, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/769

Originally assigned to: @catthehacker on GitHub.

Nothing which blocks this PR,
I think you aren't really aware of the behavior of the matrix include statement, (this is not introduced in this PR, but not fixed either)

Example Workflow run:
https://github.com/actions/runner/actions/runs/1082604590/workflow

This workflow demonstrates that includes needs to be handeled differently, if your matrix cross product is non empty and you have includes.

In my c# implementation of this,

Create the cross product (this seems to work in act with this PR)
apply excludes (this seems to work in act with this PR)
Merge the cross product if all member which are both in the cross product and include mapping are equal (added members or matrix entries to the cross product via include are not considered), otherwise do it like this code does.

Well this might be not perfect either, but this seems for me to be more like github actions.

Originally posted by @ChristopherHX in https://github.com/nektos/act/pull/763#discussion_r680346444

Originally created by @catthehacker on GitHub (Aug 8, 2021). Original GitHub issue: https://github.com/nektos/act/issues/769 Originally assigned to: @catthehacker on GitHub. Nothing which blocks this PR, I think you aren't really aware of the behavior of the matrix include statement, (this is not introduced in this PR, but not fixed either) Example Workflow run: https://github.com/actions/runner/actions/runs/1082604590/workflow This workflow demonstrates that includes needs to be handeled differently, if your matrix cross product is non empty and you have includes. In [my c# implementation](https://github.com/ChristopherHX/runner.server/blob/5d55db086c97e9bc45e97f18fadaf4043588fdf0/src/Runner.Server/Controllers/MessageController.cs#L890-L914) of this, - Create the cross product (this seems to work in act with this PR) - apply excludes (this seems to work in act with this PR) - Merge the cross product if all member which are both in the cross product and include mapping are equal (added members or matrix entries to the cross product via include are not considered), otherwise do it like this code does. Well this might be not perfect either, but this seems for me to be more like github actions. _Originally posted by @ChristopherHX in https://github.com/nektos/act/pull/763#discussion_r680346444_

kerem

2026-03-01 21:43:47 +03:00

closed this issue
added the
kind/bug

stale-exempt

area/workflow
labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#481

No description provided.

Rows
Columns