mirror of
https://github.com/nektos/act.git
synced 2026-04-26 17:35:49 +03:00
[GH-ISSUE #694] Issue: Container keeps running after exit #440
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#440
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @KnisterPeter on GitHub (May 20, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/694
Originally assigned to: @catthehacker on GitHub.
Act version
Expected behaviour
All containers started by act should be stopped/exit as soon as act terminates.
Actual behaviour
Not sure in which condition this happens, but some containers never exit.
Steps to reproduce
Not sure.
@catthehacker commented on GitHub (May 20, 2021):
If there is at least one fail during workflow then that container will not stop.
@KnisterPeter commented on GitHub (May 20, 2021):
Oh, this is a feature? Wasn't aware of that.
And it does block system resources (to an unknown amount).
And keeps ports open (depending on what is done in the containers).
@catthehacker commented on GitHub (May 20, 2021):
Well, it certainly was "expected behaviour" from my point of view that containers don't exit although I've been thinking about making at least a flag to kill all containers, just haven't got around it yet.
Feel free to contribute something in a PR if you want 😺
@aditya-jaroli-by commented on GitHub (May 21, 2021):
Keeping the container alive helps in debugging.
@KnisterPeter commented on GitHub (May 21, 2021):
I think there should be an option to either enable or disable this feature. Not sure what a sensible default would be, but I would bet for allow to enable this would be good.
The default behavior of act shouldn't probably to debug something but to run a workflow. And when finished, every system resource should be freed. But thats just my take 😃
@catthehacker commented on GitHub (May 21, 2021):
The default behaviour is always current behaviour unless something is completely broken currently.
@catthehacker commented on GitHub (May 21, 2021):
That's probably because you want to run the workflow and some people want to create an actions for GHA. It's reasonable for a container to not exit when it had issue so it could be debugged.
@ayozemr commented on GitHub (May 24, 2021):
Agreed, I use it to create actions... But I also think an argument to keep the container running will be good... like in CircleCI when you tell to keep ssh open to debug.. its not the normal usage but good to have it.
Thanks!!
@ggoretkin-bdai commented on GitHub (Feb 16, 2023):
I was looking for a way to keep the container running, and google brought me here.
The relevant flag is
@alexfornuto commented on GitHub (Jun 18, 2024):
Thanks to @ggoretkin-bdai and his >1 year old comment, which has come in clutch for me. Is this and other flags listed on the docs site (
nektosact.com) somewhere and I just missed it? If not, shouldn't it be?@YoraiLevi commented on GitHub (Nov 4, 2024):
googling github act "--reuse" leads to no meaningful documentation
However, 👇️ seem like a good enough documentation.
from now on i am using
--rmas a default